oak-team/oak-gpui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
1d0bb5a7a63b23788df07321bf201cf874ef64a6
oak-gpui/crates
T
History
LukasandConrad Irwin 1d0bb5a7a6 Make 'wrap selections in tag' work with line selection mode (#41030) 
The `wrap selections in tag` action currently did not take line_mode
into account, which means when selecting lines with `shift-v`, the
start/end tags would be inserted into the middle of the selection (where
the cursor sits)


https://github.com/user-attachments/assets/a1cbf3da-d52a-42e2-aecf-1a7b6d1dbb32

This PR fixes this behaviour by checking if the selection uses line_mode
and then adjusting start and end points accordingly.

NOTE: I looked into amending the test cases for this, but I am unsure
how to express line mode with range markers. I would appreciate some
guidance on this and then I am happy to add test cases.

After:


https://github.com/user-attachments/assets/a212c41f-b0db-4f50-866f-fced7bc677ca

Release Notes:

- Fixed `Editor: wrap selection in tags` when in vim visual line mode

---------

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
2025-10-28 03:07:41 +00:00
..
acp_thread
acp: Start sending Client Info to the Agent (#41265)
2025-10-27 10:05:50 +00:00
acp_tools
Update to acp 0.5 (#40701)
2025-10-20 13:52:05 +00:00
action_log
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
activity_indicator
Simplify environment loading code (#40531)
2025-10-23 03:57:33 +00:00
agent
agent: Fix edit_agent evals (#40921)
2025-10-24 07:48:14 +00:00
agent_servers
acp: Start sending Client Info to the Agent (#41265)
2025-10-27 10:05:50 +00:00
agent_settings
settings: Remove unused stream_edits setting in agent (#40640)
2025-10-19 15:52:28 +00:00
agent_ui
acp: Start sending Client Info to the Agent (#41265)
2025-10-27 10:05:50 +00:00
ai_onboarding
ai onboarding: Add dismiss button to the sign in banner (#40660)
2025-10-20 08:35:28 -03:00
anthropic
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
askpass
Use ShellKind::try_quote whenever we need to quote shell args (#41104)
2025-10-24 18:19:53 +02:00
assets
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_slash_command
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_slash_commands
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
assistant_text_thread
Rename assistant_context crate to assistant_text_thread (#41024)
2025-10-23 17:17:41 +00:00
audio
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
auto_update
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
auto_update_helper
Add more detailed error for remove_file (#41147)
2025-10-25 02:02:06 +00:00
auto_update_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
aws_http_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
bedrock
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
breadcrumbs
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
buffer_diff
git: Branch diff (#40188)
2025-10-23 22:38:40 -06:00
call
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
channel
clock: Cleanup ReplicaId, Lamport and Global (#40600)
2025-10-20 13:26:20 +02:00
cli
Pre-initialize global rayon threadpool (#41226)
2025-10-26 12:44:34 +00:00
client
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
clock
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
cloud_api_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cloud_api_types
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cloud_llm_client
zeta2: LLM-based context gathering (#41326)
2025-10-27 22:54:42 +00:00
cloud_zeta2_prompt
zeta2: LLM-based context gathering (#41326)
2025-10-27 22:54:42 +00:00
codestral
Add support for changing the Codestral endpoint (#41116)
2025-10-27 16:00:27 +00:00
collab
Remove PostgREST (#41299)
2025-10-27 13:27:59 -04:00
collab_ui
collab: Add 'Copy channel notes link' to right click menu on channels (#41298)
2025-10-27 17:00:36 +00:00
collections
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
command_palette
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
command_palette_hooks
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
component
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
context_server
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
copilot
Add support for GitHub Copilot /responses endpoint (#40762)
2025-10-24 13:25:58 -06:00
crashes
crashes: Avoid crash handler on detached threads (#40883)
2025-10-23 21:04:22 +00:00
credentials_provider
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
dap
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
dap_adapters
Use ShellKind::try_quote whenever we need to quote shell args (#41104)
2025-10-24 18:19:53 +02:00
db
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debug_adapter_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debugger_tools
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debugger_ui
languages: Add inline values support for JavaScript, TypeScript, and TSX (#40914)
2025-10-25 22:51:59 +00:00
deepseek
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
denoise
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
diagnostics
workspace: Handle non-cloneable items better (#41215)
2025-10-26 13:24:26 +00:00
docs_preprocessor
docs: Ensure macOS and Linux keybindings are escaped in HTML (#39802)
2025-10-23 14:13:35 -04:00
edit_prediction
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
edit_prediction_button
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
edit_prediction_context
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
editor
Make 'wrap selections in tag' work with line selection mode (#41030)
2025-10-28 03:07:41 +00:00
eval
eval: Port to agent2 (#40704)
2025-10-22 17:55:26 +00:00
explorer_command_injector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
extension
gpui: Add a timeout to #[gpui::test] tests (#41303)
2025-10-28 01:37:41 +00:00
extension_api
Windows: Fix issues with paths in extensions (#37811)
2025-09-11 13:56:06 -07:00
extension_cli
ACP Extensions (#40663)
2025-10-24 07:52:51 -04:00
extension_host
gpui: Add a timeout to #[gpui::test] tests (#41303)
2025-10-28 01:37:41 +00:00
extensions_ui
Add Tailwind CSS and Ruff to built-in features list (#41285)
2025-10-27 12:38:56 -03:00
feature_flags
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
feedback
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
file_finder
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
file_icons
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fs
git: Branch diff (#40188)
2025-10-23 22:38:40 -06:00
fs_benchmarks
fs: Reintroduce benchmarks crate (#40689)
2025-10-20 10:30:06 +00:00
fsevent
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fuzzy
file_finder: Include worktree root name in multi-worktrees workspace (#40415)
2025-10-20 23:54:56 +03:00
git
git: Branch diff (#40188)
2025-10-23 22:38:40 -06:00
git_hosting_providers
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
git_ui
workspace: Handle non-cloneable items better (#41215)
2025-10-26 13:24:26 +00:00
go_to_line
editor: Fix panics in CursorPosition::update_position (#41237)
2025-10-27 08:26:39 +00:00
google_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
gpui
gpui: Add a timeout to #[gpui::test] tests (#41303)
2025-10-28 01:37:41 +00:00
gpui_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
gpui_tokio
workspace: Handle non-cloneable items better (#41215)
2025-10-26 13:24:26 +00:00
html_to_markdown
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
http_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
http_client_tls
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
icons
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
image_viewer
workspace: Handle non-cloneable items better (#41215)
2025-10-26 13:24:26 +00:00
inspector_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
install_cli
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
journal
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
json_schema_store
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
keymap_editor
keymap_editor: Clear action query when showing matching keybindings (#41296)
2025-10-27 17:49:13 +01:00
language
zeta2: LLM-based context gathering (#41326)
2025-10-27 22:54:42 +00:00
language_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_model
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
language_models
Add support for GitHub Copilot /responses endpoint (#40762)
2025-10-24 13:25:58 -06:00
language_onboarding
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_selector
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
language_tools
workspace: Handle non-cloneable items better (#41215)
2025-10-26 13:24:26 +00:00
languages
zeta2: LLM-based context gathering (#41326)
2025-10-27 22:54:42 +00:00
line_ending_selector
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
livekit_api
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
livekit_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
lmstudio
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
lsp
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
markdown
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
markdown_preview
markdown: Add support for HTML lists (#39553)
2025-10-25 20:15:17 +00:00
media
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
menu
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
migrator
Support relative line number on wrapped lines (#39268)
2025-10-27 20:20:45 -06:00
mistral
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
multi_buffer
Support relative line number on wrapped lines (#39268)
2025-10-27 20:20:45 -06:00
nc
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
net
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
node_runtime
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
notifications
sum_tree: Implement recursive Sumtree::find, use it over Cursor::seek if possible (#40700)
2025-10-20 17:20:09 +00:00
ollama
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
onboarding
workspace: Handle non-cloneable items better (#41215)
2025-10-26 13:24:26 +00:00
open_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
open_router
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
outline
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
outline_panel
zeta2: LLM-based context gathering (#41326)
2025-10-27 22:54:42 +00:00
panel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
paths
Use paths::external_agents_dir (#41286)
2025-10-27 15:24:44 +00:00
picker
debugger: Fix debug scenario picker not showing language subtitles (#40977)
2025-10-23 07:37:37 +00:00
prettier
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
project
Fix unwrap in branch diff (#41330)
2025-10-28 02:24:54 +00:00
project_panel
Fix the project diff sometimes missing updates (#40662)
2025-10-23 16:46:27 +00:00
project_symbols
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
prompt_store
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
proto
git: Branch diff (#40188)
2025-10-23 22:38:40 -06:00
recent_projects
Notify on opening WSL paths outside of wsl (#40195)
2025-10-25 01:44:32 +00:00
refineable
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
release_channel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
remote
remote: Fall back to SCP if SFTP fails (#41255)
2025-10-27 15:01:13 +01:00
remote_server
Pre-initialize global rayon threadpool (#41226)
2025-10-26 12:44:34 +00:00
repl
workspace: Handle non-cloneable items better (#41215)
2025-10-26 13:24:26 +00:00
reqwest_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
rich_text
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
rope
rope: Micro optimize the creation of masks (#41132)
2025-10-27 16:16:16 +01:00
rpc
ACP Extensions (#40663)
2025-10-24 07:52:51 -04:00
rules_library
rules library: Improve empty state & fix quirks on Windows (#41064)
2025-10-23 21:45:48 -03:00
scheduler
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
schema_generator
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
search
Add buffer_search_deployed key context (#41193)
2025-10-27 20:37:37 -06:00
semantic_version
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
session
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings
Support relative line number on wrapped lines (#39268)
2025-10-27 20:20:45 -06:00
settings_json
settings_ui: Show migration banner (#41112)
2025-10-27 10:13:26 -04:00
settings_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings_profile_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings_ui
Support relative line number on wrapped lines (#39268)
2025-10-27 20:20:45 -06:00
snippet
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
snippet_provider
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
snippets_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sqlez
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sqlez_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
story
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
storybook
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
streaming_diff
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sum_tree
editor: Fix panics in CursorPosition::update_position (#41237)
2025-10-27 08:26:39 +00:00
supermaven
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
supermaven_api
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
svg_preview
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
system_specs
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
tab_switcher
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
task
Use ShellKind::try_quote whenever we need to quote shell args (#41104)
2025-10-24 18:19:53 +02:00
tasks_ui
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
telemetry
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
telemetry_events
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
terminal
Fix task terminal split (#41218)
2025-10-26 10:01:40 +00:00
terminal_view
workspace: Handle non-cloneable items better (#41215)
2025-10-26 13:24:26 +00:00
text
Pre-initialize global rayon threadpool (#41226)
2025-10-26 12:44:34 +00:00
theme
theme: Fix entry could appear transparent on hover with certain themes (#40944)
2025-10-23 04:23:25 +05:30
theme_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme_importer
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
time_format
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
title_bar
Fix the project diff sometimes missing updates (#40662)
2025-10-23 16:46:27 +00:00
toolchain_selector
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
ui
ACP Extensions (#40663)
2025-10-24 07:52:51 -04:00
ui_input
ui_input: Don’t focus previous on decrement in NumberField (#41095)
2025-10-24 14:03:01 +00:00
ui_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
ui_prompt
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
util
Fix shell welcome prompt showing up in Zed's stdout (#41311)
2025-10-27 20:04:36 +00:00
util_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
vercel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
vim
Make 'wrap selections in tag' work with line selection mode (#41030)
2025-10-28 03:07:41 +00:00
vim_mode_setting
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
watch
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
web_search
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
web_search_providers
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
workspace
Add buffer_search_deployed key context (#41193)
2025-10-27 20:37:37 -06:00
worktree
persistence: More error contexts (#40787)
2025-10-21 11:29:43 +00:00
worktree_benchmarks
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
x_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zed
cli: Use --wait to prefer focused window (#41051)
2025-10-27 15:58:41 +00:00
zed_actions
Notify on opening WSL paths outside of wsl (#40195)
2025-10-25 01:44:32 +00:00
zed_env_vars
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zeta
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
zeta2
zeta2: LLM-based context gathering (#41326)
2025-10-27 22:54:42 +00:00
zeta2_tools
zeta2: LLM-based context gathering (#41326)
2025-10-27 22:54:42 +00:00
zeta_cli
zeta2: LLM-based context gathering (#41326)
2025-10-27 22:54:42 +00:00
zlog
gpui: Add a timeout to #[gpui::test] tests (#41303)
2025-10-28 01:37:41 +00:00
zlog_settings
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00