Kirill Bulatov 75c5344754 Fix completion labels becoming overly large due to LSP completion items with newlines (#23407) ...

Reworks https://github.com/zed-industries/zed/pull/23030 and
https://github.com/zed-industries/zed/pull/15087
Closes https://github.com/zed-industries/zed/issues/23352
Closes https://github.com/zed-industries/zed/issues/23310 

Zed's completion items use `label` from LSP completion items as a base
to show in the list:
https://github.com/zed-industries/zed/blob/d290da7dac922fdc67c4774cdd371fba23fe62e3/crates/project/src/lsp_store.rs#L4371-L4374

Besides that, certain language plugins append `detail` or
`label_details.description` as a suffix:
https://github.com/zed-industries/zed/blob/d290da7dac922fdc67c4774cdd371fba23fe62e3/crates/languages/src/vtsls.rs#L178-L188

Either of these 3 properties may return `\n` (or multiple) in it,
spoiling Zed's completion menu, which uses `UniformList` to render those
items: a uniform list uses common, minimum possible height for each
element, and `\n` bloats that overly.

Good approach would be to use something else:
https://github.com/zed-industries/zed/issues/21403 but that has its own
drawbacks and relatively hard to use instead (?).

We could follow VSCode's approach and move away all but `label` from
`CodeLabel.text` to the side, where the documentation is, but that does
not solve the issue with `details` having newlines.

So, for now, sanitize all labels and remove any newlines from them. If
newlines are found, also replace whitespace sequences if there's more
than 1 in a row.

Later, this approach can be improved similarly to how Helix and Zed's
inline completions do: rendering a "ghost" text, showing the
completion's edit applied to the editor.

Release Notes:

- Fixed completion labels becoming overly large due to LSP completion
items with newlines

2025-01-21 17:55:41 +02:00

..

bash

Add textobjects queries (#20924)

2024-12-03 10:37:01 -07:00

c

Use standard injection.language and injection.content captures (#22268)

2025-01-07 18:17:49 +00:00

cpp

Use standard injection.language and injection.content captures (#22268)

2025-01-07 18:17:49 +00:00

css

Add textobjects queries (#20924)

2024-12-03 10:37:01 -07:00

diff

Improve diff syntax highlighting queries (#21740)

2024-12-12 15:18:36 -08:00

go

Use standard injection.language and injection.content captures (#22268)

2025-01-07 18:17:49 +00:00

gomod

Add "tool" support to go.mod (#22995)

2025-01-15 17:44:28 +02:00

gowork

File context for assistant panel (#9712)

2024-03-29 13:55:01 -07:00

javascript

Use standard injection.language and injection.content captures (#22268)

2025-01-07 18:17:49 +00:00

jsdoc

Add language icons to the language selector (#21298)

2024-12-02 15:01:09 -03:00

json

Add textobjects queries (#20924)

2024-12-03 10:37:01 -07:00

jsonc

Add textobjects queries (#20924)

2024-12-03 10:37:01 -07:00

markdown

Use standard injection.language and injection.content captures (#22268)

2025-01-07 18:17:49 +00:00

markdown-inline

Hide Markdown-Inline language from users with a new 'hidden' flag on language configs (#17104)

2024-08-29 11:23:33 -07:00

python

python: Add capture groups for builtin types, builtin attribute decorators, class inheritance, function arguments and definition keywords (#21454)

2025-01-20 19:14:19 +01:00

regex

Add language icons to the language selector (#21298)

2024-12-02 15:01:09 -03:00

rust

Fix rust runnable is not detected if comment is after #[test] attribute (#22823)

2025-01-08 12:51:23 +00:00

tsx

Use standard injection.language and injection.content captures (#22268)

2025-01-07 18:17:49 +00:00

typescript

Improve TypeScript highlights (#18525)

2025-01-10 22:00:28 +00:00

yaml

Add textobjects queries (#20924)

2024-12-03 10:37:01 -07:00

bash.rs

tasks: Expose captured variables to ContextProvider (#12134)

2024-05-22 19:45:43 +02:00

c.rs

Enable clangd's dot-to-arrow feature (#21142)

2024-11-28 10:43:25 +02:00

css.rs

Fix lang servers status set to Downloading when checking version (#22292)

2024-12-20 16:59:10 +00:00

go.rs

go: Adjust gopls path based on OS (#22727)

2025-01-06 22:04:10 +00:00

json.rs

Show configuration in language server debug logs (#23084)

2025-01-13 21:00:03 +00:00

lib.rs

Add language icons to the language selector (#21298)

2024-12-02 15:01:09 -03:00

python.rs

python: Detect pixi environments automatically (#22635)

2025-01-08 11:06:33 +00:00

rust.rs

Return back Rust completion details (#22648)

2025-01-04 11:15:09 +00:00

tailwind.rs

Fix lang servers status set to Downloading when checking version (#22292)

2024-12-20 16:59:10 +00:00

typescript.rs

Fix completion labels becoming overly large due to LSP completion items with newlines (#23407)

2025-01-21 17:55:41 +02:00

vtsls.rs

Fix completion labels becoming overly large due to LSP completion items with newlines (#23407)

2025-01-21 17:55:41 +02:00

yaml.rs

Enable yaml-language-server lookup in PATH (#22036)

2025-01-09 21:06:21 +00:00