oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
0e575b280997b346e58497725fa0609ac4f6f47c
oak-gpui/crates
T
History
Adam Mulvany 0e575b2809 helix: Fix buffer search: deploy reset to normal mode (#36917) 
## Fix: Preserve Helix mode when using  search

### Problem
When using `buffer search: deploy` in Helix mode, pressing Enter to
dismiss the search incorrectly returned to Vim NORMAL mode instead of
Helix NORMAL mode.

### Root Cause
The `search_deploy` function was resetting the entire `SearchState` to
default values when buffer search: deploy was activated. Since the
default `Mode` is `Normal`, this caused `prior_mode` to be set to Vim's
Normal mode regardless of the actual mode before search.

### Solution
Modified `search_deploy` to preserve the current mode when resetting
search state:
- Store the current mode before resetting
- Reset search state to default
- Restore the saved mode to `prior_mode`

This ensures the editor returns to the correct mode (Helix NORMAL or Vim
NORMAL) after dismissing buffer search.

### Settings

I was able to reproduce and then test the fix was successful with the
following config and have also tested with vim: default_mode commented
out to ensure that's not influencing the mode selection flow:

```
  "helix_mode": true,
  "vim_mode": true,
  "vim": {
    "default_mode": "helix_normal"
  },
```

This is on Kubuntu 24.04.

The following test combinations pass locally:

- `cargo test -p search`
- `cargo test -p vim` 
- `cargo test -p editor`
- `cargo test -p workspace`
- `cargo test -p gpui -- vim`
- `cargo test -p gpui -- helix`

Release Notes:

- Fixed Helix mode switching to Vim normal mode after using `buffer
search: deploy` to search

Closes #36872
2025-08-26 10:38:53 -06:00
..
acp_thread
acp: Update error matching (#36898)
2025-08-25 14:07:10 -06:00
acp_tools
acp: Rename dev command (#36908)
2025-08-25 16:04:44 -06:00
action_log
Enforce style lints which do not have violations (#36580)
2025-08-20 14:07:37 +02:00
activity_indicator
Enforce style lints which do not have violations (#36580)
2025-08-20 14:07:37 +02:00
agent
Revert "ai: Auto select user model when there's no default" (#36932)
2025-08-26 13:55:09 +00:00
agent2
Revert "ai: Auto select user model when there's no default" (#36932)
2025-08-26 13:55:09 +00:00
agent_servers
acp: Send user-configured MCP tools (#36910)
2025-08-26 00:55:24 +00:00
agent_settings
lints: A bunch of extra style lint fixes (#36568)
2025-08-20 12:05:58 +02:00
agent_ui
thread view: Refine tool call UI (#36937)
2025-08-26 12:55:40 -03:00
ai_onboarding
Make fields of AiUpsellCard private (#36888)
2025-08-25 17:21:20 +00:00
anthropic
Add Claude Opus 4.1 (#35653)
2025-08-05 18:16:47 +00:00
askpass
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
assets
Use IBM Plex Sans / Lilex (#36084)
2025-08-13 13:25:52 -06:00
assistant_context
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
assistant_slash_command
lints: A bunch of extra style lint fixes (#36568)
2025-08-20 12:05:58 +02:00
assistant_slash_commands
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
assistant_tool
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
assistant_tools
thread view: Fix some design papercuts (#36893)
2025-08-25 21:07:30 +02:00
audio
Add Rodio audio pipeline as alternative to current LiveKit pipeline (#36607)
2025-08-21 15:56:16 +02:00
auto_update
Fix unnecessary-mut-passed lint (#36490)
2025-08-19 14:20:01 +00:00
auto_update_helper
lints: A bunch of extra style lint fixes (#36568)
2025-08-20 12:05:58 +02:00
auto_update_ui
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
aws_http_client
…
bedrock
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
breadcrumbs
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
buffer_diff
acp: Fix panic with edit file tool (#36732)
2025-08-22 03:48:47 -04:00
call
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
channel
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
cli
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
client
Add a few more testing features (#36778)
2025-08-22 22:17:02 +00:00
clock
…
cloud_api_client
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
cloud_api_types
Establish WebSocket connection to Cloud (#35734)
2025-08-07 01:28:41 +00:00
cloud_llm_client
agent2: Add now, grep, and web search tools (#35974)
2025-08-11 15:34:34 +02:00
collab
Ensure pane: swap item right does not panic (#36765)
2025-08-22 23:28:55 +02:00
collab_ui
collab_ui: Fix channel text bleeding through buttons on hover (#36710)
2025-08-21 18:50:06 +00:00
collections
…
command_palette
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
command_palette_hooks
…
component
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
context_server
acp: Support calling tools provided by MCP servers (#36752)
2025-08-22 13:16:42 +00:00
copilot
Make word completions less intrusive (#36745)
2025-08-22 13:58:17 +00:00
crashes
Add GPU info to Sentry crashes (#36624)
2025-08-21 19:59:42 -04:00
credentials_provider
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
dap
lints: A bunch of extra style lint fixes (#36568)
2025-08-20 12:05:58 +02:00
dap_adapters
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
db
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
debug_adapter_extension
…
debugger_tools
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
debugger_ui
remote: Fetch shell on ssh remote to use for preparing commands (#36690)
2025-08-21 19:08:26 +02:00
deepseek
…
diagnostics
Remove redundant Cargo diagnostics settings (#36795)
2025-08-23 07:03:36 +00:00
docs_preprocessor
docs: Add table of all actions (#36642)
2025-08-20 23:41:06 +00:00
edit_prediction
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
edit_prediction_button
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
editor
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
eval
Fix clippy::println_empty_string, clippy::while_let_on_iterator, clippy::while_let_on_iterator lint style violations (#36613)
2025-08-20 20:14:30 +02:00
explorer_command_injector
…
extension
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
extension_api
lints: A bunch of extra style lint fixes (#36568)
2025-08-20 12:05:58 +02:00
extension_cli
Remove /docs slash command (#36325)
2025-08-16 19:00:31 +00:00
extension_host
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
extensions_ui
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
feature_flags
acp: Enable feature flag for everyone (#36928)
2025-08-26 15:30:26 +02:00
feedback
Add GPU info to Sentry crashes (#36624)
2025-08-21 19:59:42 -04:00
file_finder
util: Fix edge case when parsing paths (#36025)
2025-08-25 12:28:33 +03:00
file_icons
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
fs
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
fsevent
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
fuzzy
Prevent out of bounds access in recursive_score_match (#35630)
2025-08-06 10:53:20 +02:00
git
Fix clippy::println_empty_string, clippy::while_let_on_iterator, clippy::while_let_on_iterator lint style violations (#36613)
2025-08-20 20:14:30 +02:00
git_hosting_providers
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
git_ui
Revert "ai: Auto select user model when there's no default" (#36932)
2025-08-26 13:55:09 +00:00
go_to_line
Enforce style lints which do not have violations (#36580)
2025-08-20 14:07:37 +02:00
google_ai
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
gpui
Fix constant thread creation on Windows (#36779)
2025-08-25 12:45:28 -07:00
gpui_macros
clippy: println_empty_string & non_minimal_cfg (#36614)
2025-08-20 18:45:40 +00:00
gpui_tokio
Use Tokio::spawn instead of getting an executor handle (#36701)
2025-08-21 17:19:57 +00:00
html_to_markdown
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
http_client
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
http_client_tls
…
icons
thread view: Add more UI improvements (#36750)
2025-08-22 09:52:44 -03:00
image_viewer
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
inspector_ui
Fix crash when opening inspector on Windows debug build (#36829)
2025-08-24 11:01:42 +00:00
install_cli
Fix clippy::needless_borrow lint violations (#36444)
2025-08-18 21:54:35 +00:00
jj
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
jj_ui
…
journal
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
language
tab_switcher: Add support for diagnostics (#34547)
2025-08-25 20:18:03 +00:00
language_extension
Fix clippy::needless_borrow lint violations (#36444)
2025-08-18 21:54:35 +00:00
language_model
Revert "ai: Auto select user model when there's no default" (#36932)
2025-08-26 13:55:09 +00:00
language_models
Revert "ai: Auto select user model when there's no default" (#36932)
2025-08-26 13:55:09 +00:00
language_selector
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
language_tools
Do not show directories in the InvalidBufferView (#36906)
2025-08-25 21:16:37 +00:00
languages
Revert "Capture shorthand_field_initializer and modules in Rust highlights (#35842)" (#36880)
2025-08-25 15:51:31 +00:00
livekit_api
…
livekit_client
Add Rodio audio pipeline as alternative to current LiveKit pipeline (#36607)
2025-08-21 15:56:16 +02:00
lmstudio
…
lsp
Stop waiting for part of LSP responses on remote Collab clients' part (#36557)
2025-08-21 09:24:34 +03:00
markdown
thread view: Refine tool call UI (#36937)
2025-08-26 12:55:40 -03:00
markdown_preview
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
media
…
menu
…
migrator
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
mistral
language_models: Add thinking to Mistral Provider (#32476)
2025-08-09 15:25:47 -04:00
multi_buffer
multi_buffer: Pre-allocate IDs when editing (#36819)
2025-08-24 09:59:32 +03:00
nc
…
net
…
node_runtime
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
notifications
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
ollama
ollama: Add support for gpt-oss (#35648)
2025-08-06 10:44:15 -04:00
onboarding
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
open_ai
open_ai: Remove model field from ResponseStreamEvent (#36902)
2025-08-25 19:50:08 +00:00
open_router
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
outline
…
outline_panel
Fix more improper uses of the buffer_id field of Anchor (#36636)
2025-08-21 09:24:34 -04:00
panel
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
paths
lints: A bunch of extra style lint fixes (#36568)
2025-08-20 12:05:58 +02:00
picker
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
prettier
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
project
tab_switcher: Add support for diagnostics (#34547)
2025-08-25 20:18:03 +00:00
project_panel
Support disabling drag-and-drop in Project Panel (#36719)
2025-08-26 13:35:45 +00:00
project_symbols
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
prompt_store
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
proto
Be more lenient when dealing with rust-analyzer's flycheck commands (#36782)
2025-08-22 22:55:50 +00:00
recent_projects
Restructure persistence of remote workspaces to make room for WSL and other non-ssh remote projects (#36714)
2025-08-22 14:10:45 -07:00
refineable
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
release_channel
…
remote
Remote: Change "sh -c" to "sh -lc" to make config in $HOME/.profile effective (#36760)
2025-08-25 21:40:53 -06:00
remote_server
remote_server: Improve error reporting (#33770)
2025-08-25 20:23:29 +00:00
repl
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
reqwest_client
lints: A bunch of extra style lint fixes (#36568)
2025-08-20 12:05:58 +02:00
rich_text
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
rope
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
rpc
Fix overlooked Clippy lints (#36659)
2025-08-21 06:48:04 +00:00
rules_library
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
schema_generator
…
search
Ensure pane: swap item right does not panic (#36765)
2025-08-22 23:28:55 +02:00
semantic_index
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
semantic_version
…
session
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
settings
Add Rodio audio pipeline as alternative to current LiveKit pipeline (#36607)
2025-08-21 15:56:16 +02:00
settings_profile_selector
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
settings_ui
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
snippet
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
snippet_provider
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
snippets_ui
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
sqlez
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
sqlez_macros
…
story
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
storybook
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
streaming_diff
Fix clippy::needless_borrow lint violations (#36444)
2025-08-18 21:54:35 +00:00
sum_tree
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
supermaven
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
supermaven_api
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
svg_preview
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
system_specs
Add GPU info to Sentry crashes (#36624)
2025-08-21 19:59:42 -04:00
tab_switcher
tab_switcher: Add support for diagnostics (#34547)
2025-08-25 20:18:03 +00:00
task
remote: Fetch shell on ssh remote to use for preparing commands (#36690)
2025-08-21 19:08:26 +02:00
tasks_ui
Fix clippy::len_zero lint style violations (#36589)
2025-08-20 14:35:59 +00:00
telemetry
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
telemetry_events
Remove old telemetry events and transformation layer (#36263)
2025-08-15 15:37:52 -04:00
terminal
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
terminal_view
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
text
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
theme
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
theme_extension
…
theme_importer
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
theme_selector
Redesign and clean up all icons across Zed (#35856)
2025-08-08 15:34:36 -03:00
time_format
…
title_bar
Enforce style lints which do not have violations (#36580)
2025-08-20 14:07:37 +02:00
toolchain_selector
remote: Fix toolchain RPC messages not being handled because of the entity getting dropped (#36665)
2025-08-21 09:37:45 +00:00
ui
thread view: Add link to docs in the toolbar plus menu (#36883)
2025-08-25 17:34:55 -03:00
ui_input
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
ui_macros
…
ui_prompt
…
util
remote: Fetch shell on ssh remote to use for preparing commands (#36690)
2025-08-21 19:08:26 +02:00
util_macros
…
vercel
openai: Don't send prompt_cache_key for OpenAI-compatible models (#36231)
2025-08-15 13:54:24 +03:00
vim
helix: Fix buffer search: deploy reset to normal mode (#36917)
2025-08-26 10:38:53 -06:00
vim_mode_setting
…
watch
acp: Model-specific prompt capabilities for 1PA (#36879)
2025-08-25 14:28:11 -04:00
web_search
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
web_search_providers
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
workspace
Fix Sqlite newline syntax in workspace migration (#36916)
2025-08-25 22:21:05 -07:00
worktree
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
x_ai
lints: A bunch of extra style lint fixes (#36568)
2025-08-20 12:05:58 +02:00
zed
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
zed_actions
acp: Add Reauthenticate to dropdown (#36878)
2025-08-25 15:46:07 +00:00
zeta
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
zeta_cli
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
zlog
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
zlog_settings
…