oak-team/oak-gpui
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
00ff89f00fc771c41c36bb577c6e50893e4a9625
oak-gpui/crates
T
History
Danilo Leal 00ff89f00f agent_ui: Make single file review actions match panel (#41718) 
When we introduced the ACP-based agent panel, the condition that the
"review" | "reject" | "keep" buttons observed to be displayed got
mismatched between the panel and the pane (when in the single file
review scenario). In the panel, the buttons appear as soon as there are
changed buffers, whereas in the pane, they appear when response
generation is done.

I believe that making them appear at the same time, observing the same
condition, is the desired behavior. Thus, I think the panel behavior is
more correct, because there are loads of times where agent response
generation isn't technically done (e.g., when there's a command waiting
for permission to be run) but the _file edit_ has already been performed
and is in a good state to be already accepted or rejected.

So, this is what this PR is doing; effectively removing the "generating"
state from the agent diff, and switching to `EditorState::Reviewing`
when there are changed buffers.

Release Notes:

- Improved agent edit single file reviews by making the "reject" and
"accept" buttons appear at the same time.
2025-11-02 14:30:50 -03:00
..
acp_thread
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
acp_tools
acp_tools: Add button to clear messages (#41206)
2025-10-29 16:40:02 +01:00
action_log
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
activity_indicator
Support numeric tokens in work report LSP requests (#41448)
2025-10-29 19:35:16 +00:00
agent
agent: Model name context (#41490)
2025-10-31 16:12:46 +00:00
agent_servers
acp: Start sending Client Info to the Agent (#41265)
2025-10-27 10:05:50 +00:00
agent_settings
settings: Remove unused stream_edits setting in agent (#40640)
2025-10-19 15:52:28 +00:00
agent_ui
agent_ui: Make single file review actions match panel (#41718)
2025-11-02 14:30:50 -03:00
ai_onboarding
ai onboarding: Add dismiss button to the sign in banner (#40660)
2025-10-20 08:35:28 -03:00
anthropic
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
askpass
Use ShellKind::try_quote whenever we need to quote shell args (#41104)
2025-10-24 18:19:53 +02:00
assets
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_slash_command
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_slash_commands
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
assistant_text_thread
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
audio
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
auto_update
windows: Hide background helpers behind CREATE_NO_WINDOW (#41737)
2025-11-02 09:15:01 +01:00
auto_update_helper
Adjust Windows fusion manifests (#41408)
2025-10-28 20:21:31 -04:00
auto_update_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
aws_http_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
bedrock
bedrock: Add support for Claude Haiku 4.5 model (#41045)
2025-10-29 16:41:43 +01:00
breadcrumbs
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
buffer_diff
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
call
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
channel
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
cli
rope: Prevent stack overflows by bumping rayon stack sizes (#41397)
2025-10-28 20:21:49 +00:00
client
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
clock
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
cloud_api_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cloud_api_types
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cloud_llm_client
zeta2: LLM-based context gathering (#41326)
2025-10-27 22:54:42 +00:00
cloud_zeta2_prompt
zeta cli: Add convert-example command (#41608)
2025-11-01 19:35:04 +00:00
codestral
edit prediction: Add ability to switch providers from the status bar menu (#41504)
2025-10-29 22:16:13 -03:00
collab
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
collab_ui
collab panel: Open selected channel notes (#41560)
2025-10-30 13:10:19 +00:00
collections
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
command_palette
command palette: Make footer buttons justified to the right (#41382)
2025-10-28 16:15:44 -03:00
command_palette_hooks
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
component
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
context_server
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
copilot
Add support for GitHub Copilot /responses endpoint (#40762)
2025-10-24 13:25:58 -06:00
crashes
crashes: Avoid crash handler on detached threads (#40883)
2025-10-23 21:04:22 +00:00
credentials_provider
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
dap
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
dap_adapters
debugger: Add program and module path fallbacks for debugpy toolchain (#40975)
2025-11-01 17:30:13 -04:00
db
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debug_adapter_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debugger_tools
Keep selection in SwitchToHelixNormalMode (#41583)
2025-10-31 01:53:46 +00:00
debugger_ui
debugger: Polish breakpoint list UI (#41598)
2025-10-30 16:15:21 -04:00
deepseek
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
denoise
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
diagnostics
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
docs_preprocessor
docs: Ensure macOS and Linux keybindings are escaped in HTML (#39802)
2025-10-23 14:13:35 -04:00
edit_prediction
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
edit_prediction_button
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
edit_prediction_context
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
editor
editor: Fix refresh_linked_ranges panics due to old snapshot use (#41657)
2025-10-31 17:39:55 +01:00
eval
eval: Port to agent2 (#40704)
2025-10-22 17:55:26 +00:00
explorer_command_injector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
extension
gpui: Add a timeout to #[gpui::test] tests (#41303)
2025-10-28 01:37:41 +00:00
extension_api
Windows: Fix issues with paths in extensions (#37811)
2025-09-11 13:56:06 -07:00
extension_cli
Fix categorization of agent server extensions (#41689)
2025-10-31 21:18:22 +00:00
extension_host
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
extensions_ui
Add included agents in extensions search (#41679)
2025-10-31 16:45:39 -03:00
feature_flags
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
feedback
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
file_finder
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
file_icons
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fs
windows: Hide background helpers behind CREATE_NO_WINDOW (#41737)
2025-11-02 09:15:01 +01:00
fs_benchmarks
fs: Reintroduce benchmarks crate (#40689)
2025-10-20 10:30:06 +00:00
fsevent
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fuzzy
file_finder: Include worktree root name in multi-worktrees workspace (#40415)
2025-10-20 23:54:56 +03:00
git
editor: Limit the amount of git processes spawned per multibuffer (#41472)
2025-10-29 16:08:41 +00:00
git_hosting_providers
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
git_ui
Give visual feedback when an operation is pending (#41686)
2025-11-01 04:24:59 +00:00
go_to_line
Reduce amount of foreground tasks spawned on multibuffer/editor updates (#41479)
2025-10-30 17:40:56 +00:00
google_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
gpui
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
gpui_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
gpui_tokio
workspace: Handle non-cloneable items better (#41215)
2025-10-26 13:24:26 +00:00
html_to_markdown
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
http_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
http_client_tls
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
icons
settings_ui: Add ability to copy a link for a given setting (#41172)
2025-10-29 13:15:08 -03:00
image_viewer
workspace: Handle non-cloneable items better (#41215)
2025-10-26 13:24:26 +00:00
inspector_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
install_cli
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
journal
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
json_schema_store
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
keymap_editor
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
language
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
language_extension
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
language_model
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
language_models
ollama: Add button for refreshing available models (#38181)
2025-10-31 18:12:02 +00:00
language_onboarding
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_selector
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
language_tools
Keep selection in SwitchToHelixNormalMode (#41583)
2025-10-31 01:53:46 +00:00
languages
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
line_ending_selector
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
livekit_api
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
livekit_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
lmstudio
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
lsp
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
markdown
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
markdown_preview
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
media
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
menu
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
migrator
Revert "Support relative line number on wrapped lines (#39268)" (#41450)
2025-10-29 11:07:23 +00:00
mistral
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
multi_buffer
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
nc
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
net
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
node_runtime
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
notifications
sum_tree: Implement recursive Sumtree::find, use it over Cursor::seek if possible (#40700)
2025-10-20 17:20:09 +00:00
ollama
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
onboarding
workspace: Handle non-cloneable items better (#41215)
2025-10-26 13:24:26 +00:00
open_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
open_router
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
outline
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
outline_panel
outline_panel: Fix collapse/expand all entries (#41342)
2025-10-30 21:48:37 +00:00
panel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
paths
Use paths::external_agents_dir (#41286)
2025-10-27 15:24:44 +00:00
picker
Increased the max height of pickers (#41617)
2025-10-31 04:26:36 +00:00
prettier
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
project
git: Make GitPanel more responsive to long-running staging ops (#41667)
2025-10-31 22:47:49 +01:00
project_panel
project panel: Remove extra separator when "Rename" is hidden (#41639)
2025-10-31 13:55:08 +00:00
project_symbols
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
prompt_store
prompt_store: Remove unused code (#41473)
2025-10-29 16:27:30 +00:00
proto
Support numeric tokens in work report LSP requests (#41448)
2025-10-29 19:35:16 +00:00
recent_projects
recent_projects: Surface project opening errors to user (#41308)
2025-10-28 06:44:44 +00:00
refineable
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
release_channel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
remote
recent_projects: Surface project opening errors to user (#41308)
2025-10-28 06:44:44 +00:00
remote_server
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
repl
Propagate Jupyter client errors (#40886)
2025-10-28 14:45:27 +00:00
reqwest_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
rich_text
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
rope
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
rpc
ACP Extensions (#40663)
2025-10-24 07:52:51 -04:00
rules_library
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
scheduler
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
schema_generator
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
search
Keep selection in SwitchToHelixNormalMode (#41583)
2025-10-31 01:53:46 +00:00
semantic_version
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
session
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings
settings_ui: Add edit prediction settings (#41480)
2025-10-29 16:18:06 -03:00
settings_json
settings_ui: Show migration banner (#41112)
2025-10-27 10:13:26 -04:00
settings_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings_profile_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings_ui
settings_ui: Close the settings window when going to the JSON file (#41491)
2025-10-29 19:19:36 -03:00
snippet
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
snippet_provider
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
snippets_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sqlez
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sqlez_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
story
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
storybook
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
streaming_diff
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
sum_tree
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
supermaven
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
supermaven_api
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
svg_preview
svg_preview: Update preview on every buffer edit (#41270)
2025-10-29 18:49:39 +01:00
system_specs
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
tab_switcher
Fix tab switcher spacing bug (#41329)
2025-10-28 03:00:55 -04:00
task
Use ShellKind::try_quote whenever we need to quote shell args (#41104)
2025-10-24 18:19:53 +02:00
tasks_ui
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
telemetry
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
telemetry_events
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
terminal
terminal: Kill the terminal child process, not the terminal process on exit (#41631)
2025-10-31 15:01:50 +00:00
terminal_view
terminal: Kill the terminal child process, not the terminal process on exit (#41631)
2025-10-31 15:01:50 +00:00
text
editor: Fix refresh_linked_ranges panics due to old snapshot use (#41657)
2025-10-31 17:39:55 +01:00
theme
theme: Fix entry could appear transparent on hover with certain themes (#40944)
2025-10-23 04:23:25 +05:30
theme_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme_importer
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
time_format
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
title_bar
windows: Fix click bleeding through collab follow (#41726)
2025-11-02 07:35:11 +00:00
toolchain_selector
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
ui
ui: Fix popover menu not restoring focus to the previously focused element (#41751)
2025-11-02 16:56:58 +01:00
ui_input
ui_input: Don’t focus previous on decrement in NumberField (#41095)
2025-10-24 14:03:01 +00:00
ui_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
ui_prompt
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
util
Fix shell welcome prompt showing up in Zed's stdout (#41311)
2025-10-27 20:04:36 +00:00
util_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
vercel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
vim
vim: Only focus when associated editor is also focused (#41487)
2025-10-31 15:04:54 +00:00
vim_mode_setting
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
watch
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
web_search
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
web_search_providers
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
workspace
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
worktree
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
worktree_benchmarks
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
x_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zed
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
zed_actions
settings_ui: Remove OpenSettingsAt from command palette (#41358)
2025-10-29 16:29:53 +00:00
zed_env_vars
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zeta
sum_tree: Replace rayon with futures (#41586)
2025-10-31 10:39:01 +00:00
zeta2
zeta cli: Add convert-example command (#41608)
2025-11-01 19:35:04 +00:00
zeta2_tools
zeta2: Expose llm-based context retrieval via zeta_cli (#41584)
2025-10-30 21:41:09 +00:00
zeta_cli
zeta cli: Add convert-example command (#41608)
2025-11-01 19:35:04 +00:00
zlog
svg_preview: Update preview on every buffer edit (#41270)
2025-10-29 18:49:39 +01:00
zlog_settings
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00