oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

debugger: Make historic snapshot button a dropdown menu (#44307)

Browse Source 
This allows users to select any snapshot in the debugger history feature
and go back to the active session snapshot.

We also change variable names to use hsitoric snapshot instead of
history and move the snapshot icon to the back of the debugger top
control strip.


https://github.com/user-attachments/assets/805de8d0-30c1-4719-8af7-2d47e1df1da4

Release Notes:

- N/A

Co-authored-by: Anthony Eid <hello@anthonyeid.me>
This commit is contained in:
Remco Smits
2025-12-06 21:08:33 +00:00
committed by GitHub
co-authored by Anthony Eid
parent 4577e1bf8f
commit ef76f07b1e
4 changed files with 190 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/project/src/debugger/session.rs
+16 -8
View File
@@ -1436,15 +1436,23 @@ impl Session {
.push_back(std::mem::take(&mut self.active_snapshot));
}
pub fn history(&self) -> &VecDeque<SessionSnapshot> {
pub fn historic_snapshots(&self) -> &VecDeque<SessionSnapshot> {
&self.snapshots
}
pub fn go_back_to_history(&mut self, ix: Option<usize>, cx: &mut Context<'_, Session>) {
pub fn select_historic_snapshot(&mut self, ix: Option<usize>, cx: &mut Context<Session>) {
if self.selected_snapshot_index == ix {
return;
}
if self
.selected_snapshot_index
.is_some_and(|ix| self.snapshots.len() <= ix)
{
debug_panic!("Attempted to select a debug session with an out of bounds index");
return;
}
self.selected_snapshot_index = ix;
if ix.is_some() {
@@ -1454,7 +1462,7 @@ impl Session {
cx.notify();
}
pub fn active_history(&self) -> Option<usize> {
pub fn active_snapshot_index(&self) -> Option<usize> {
self.selected_snapshot_index
}
@@ -2272,7 +2280,7 @@ impl Session {
}
pub fn continue_thread(&mut self, thread_id: ThreadId, cx: &mut Context<Self>) {
self.go_back_to_history(None, cx);
self.select_historic_snapshot(None, cx);
let supports_single_thread_execution_requests =
self.capabilities.supports_single_thread_execution_requests;
@@ -2309,7 +2317,7 @@ impl Session {
granularity: SteppingGranularity,
cx: &mut Context<Self>,
) {
self.go_back_to_history(None, cx);
self.select_historic_snapshot(None, cx);
let supports_single_thread_execution_requests =
self.capabilities.supports_single_thread_execution_requests;
@@ -2341,7 +2349,7 @@ impl Session {
granularity: SteppingGranularity,
cx: &mut Context<Self>,
) {
self.go_back_to_history(None, cx);
self.select_historic_snapshot(None, cx);
let supports_single_thread_execution_requests =
self.capabilities.supports_single_thread_execution_requests;
@@ -2373,7 +2381,7 @@ impl Session {
granularity: SteppingGranularity,
cx: &mut Context<Self>,
) {
self.go_back_to_history(None, cx);
self.select_historic_snapshot(None, cx);
let supports_single_thread_execution_requests =
self.capabilities.supports_single_thread_execution_requests;
@@ -2405,7 +2413,7 @@ impl Session {
granularity: SteppingGranularity,
cx: &mut Context<Self>,
) {
self.go_back_to_history(None, cx);
self.select_historic_snapshot(None, cx);
let supports_single_thread_execution_requests =
self.capabilities.supports_single_thread_execution_requests;