From de1d301993251a502a905e0f21b6dc64f05ddf57 Mon Sep 17 00:00:00 2001 From: Conrad Irwin Date: Wed, 4 Sep 2024 12:39:24 -0600 Subject: [PATCH] Bump vtsls memory limits (#17354) Release Notes: - Bump the default memory limit for vtsls from 3GiB to 8GiB --- crates/languages/src/vtsls.rs | 3 +++ docs/src/languages/typescript.md | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/crates/languages/src/vtsls.rs b/crates/languages/src/vtsls.rs index 887a8a4d5a..5ee0f0f611 100644 --- a/crates/languages/src/vtsls.rs +++ b/crates/languages/src/vtsls.rs @@ -226,6 +226,9 @@ impl LspAdapter for VtslsLspAdapter { "suggest": { "completeFunctionCalls": true }, + "tsserver": { + "maxTsServerMemory": 8092 + }, "inlayHints": { "parameterNames": { "enabled": "all", diff --git a/docs/src/languages/typescript.md b/docs/src/languages/typescript.md index 25f0a42b10..377121abc5 100644 --- a/docs/src/languages/typescript.md +++ b/docs/src/languages/typescript.md @@ -46,7 +46,7 @@ Prettier will also be used for TypeScript files by default. To disable this: ## Large projects -`vtsls` may run out of memory on very large projects. You can configure this limit by passing the following options to the language server: +`vtsls` may run out of memory on very large projects. We default the limit to 8092 (8 GiB) vs the default of 3072 but this may not be sufficient for you: ```json { @@ -54,9 +54,9 @@ Prettier will also be used for TypeScript files by default. To disable this: "vtsls": { "initialization_options": { // For TypeScript: - "typescript": { "tsserver": { "maxTsServerMemory": 8092 } }, + "typescript": { "tsserver": { "maxTsServerMemory": 16184 } }, // For JavaScript: - "javascript": { "tsserver": { "maxTsServerMemory": 8092 } } + "javascript": { "tsserver": { "maxTsServerMemory": 16184 } } } } }