oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add more eval examples + filtering examples by language + fix git concurrent usage (#28719)

Browse Source 
Release Notes:

- N/A

---------

Co-authored-by: michael <michael@zed.dev>
Co-authored-by: agus <agus@zed.dev>
This commit is contained in:
Thomas Mickley-Doyle
2025-04-14 22:05:46 +00:00
committed by GitHub
co-authored by michael agus
parent a8b1ef3531
commit d74f0735c2
76 changed files with 365 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/eval/examples/runtime_script_refactor/criteria.md
+6
View File
@@ -0,0 +1,6 @@
1. **Added RuntimeCommands import and WebElement to page.py**
The changes add an import for `RuntimeCommands` and `WebElement` to `page.py`. The `execute_js_script` method is renamed to `execute_script` and enhanced to support execution in the context of a WebElement. The method now uses `RuntimeCommands` for script evaluation.
2. **Refactored Runtime-related commands from DomCommands to new RuntimeCommands class**
The changes move all Runtime-related command templates and methods from `DomCommands` in `dom.py` to a new `runtime.py` file. This includes `EVALUATE_TEMPLATE`, `CALL_FUNCTION_ON_TEMPLATE`, `GET_PROPERTIES`, and their associated methods. The DomCommands class now uses RuntimeCommands for JavaScript evaluation.
3. **Added Scripts constants and enhanced WebElement functionality**
The changes add a new `Scripts` class to `constants.py` containing JavaScript snippets for common operations. The `element.py` file is significantly enhanced with new methods for script execution, visibility checking, and improved click handling. New exceptions are added to `exceptions.py` for better error handling.