Add more eval examples + filtering examples by language + fix git concurrent usage (#28719)
Release Notes: - N/A --------- Co-authored-by: michael <michael@zed.dev> Co-authored-by: agus <agus@zed.dev>
This commit is contained in:
co-authored by
michael
agus
parent
a8b1ef3531
commit
d74f0735c2
@@ -0,0 +1,3 @@
|
||||
url = "https://github.com/workos/authkit-js.git"
|
||||
revision = "949345d85782a93e8f1738ec31823948ffc26301"
|
||||
language_extension = "ts"
|
||||
@@ -0,0 +1,10 @@
|
||||
1. Add a new test case in `create-client.test.ts` for when the `returnTo` option is provided during sign-out. It verifies that the sign-out URL includes the correct `return_to` query parameter with the provided URL. The test sets up a mock client, calls signOut with a returnTo value, and asserts that the resulting URL contains the expected session_id and return_to parameters while maintaining the correct API endpoint structure.
|
||||
2. Modifies the `signOut` method in `create-client.ts` to accept an optional options parameter containing a returnTo string. Instead of directly passing the sessionId to getLogoutUrl, it now passes an object containing both the sessionId and the returnTo value from the options. The method maintains its existing behavior of checking for an access token and clearing session data when a URL is available.
|
||||
3. Updates the HTTP client tests in `http-client.test.ts` to reflect the new getLogoutUrl signature. It adds a test case for the basic logout URL and a new describe block for when returnTo is provided, verifying that the URL includes the properly encoded return_to parameter. The test ensures the URL construction handles both cases correctly.
|
||||
4. Modifies the `getLogoutUrl` method in `http-client.ts` to accept an object parameter with sessionId and returnTo properties instead of just a sessionId string. It maintains the base URL construction but now conditionally adds the return_to query parameter only when a returnTo value is provided, while always including the session_id parameter. The method handles URL construction and parameter encoding internally.
|
||||
5. Updates the session initialization logic in `create-client.ts` to check for either a `workos-has-session` cookie or a refresh token (retrieved via `getRefreshToken`). This allows the client to refresh sessions even if no `code` is present in the URL, especially in development environments.
|
||||
6. Adds corresponding test coverage in `create-client.test.ts`:
|
||||
- When no code is in the URL but the `workos-has-session` cookie exists, the session should be refreshed.
|
||||
- When devMode is enabled and a refresh token is present in localStorage, the session should be refreshed.
|
||||
- When devMode is enabled but no refresh token exists, the client should be created without making any network requests.
|
||||
- When neither a code, cookie, nor refresh token is present, the client should initialize without refreshing.
|
||||
@@ -0,0 +1,3 @@
|
||||
I need to improve our logout feature. When users sign out, they should be able to specify a return URL to redirect to afterward. Right now, signing out just takes them to a default page, but we want to support custom redirects (like back to the homepage or a login screen). The URL should be safely included in the logout request. Make sure existing logouts still work normally when no redirect is specified.
|
||||
|
||||
Also, note that we updated how the client initializes its session. It should now check for either a `workos-has-session` cookie or a valid refresh token (even in devMode). This ensures that sessions are refreshed appropriately even without a code in the URL. Be sure this logic is covered by the minimum tests.
|
||||
Reference in New Issue
Block a user