oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

agent_ui: Reduce label repetitiveness on new thread menu (#42001)

Browse Source 
Mostly just removing "thread" from all external agent menu items; I
think we can do without it and it already becomes much better/cleaner.

Release Notes:

- N/A
This commit is contained in:
Danilo Leal
2025-11-05 11:45:31 -03:00
committed by GitHub
parent 27a18843d4
commit c8ada5b1ae
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/agent_ui/src/agent_configuration.rs
+1 -1
View File
@@ -1013,7 +1013,7 @@ impl AgentConfiguration {
.child(Divider::horizontal().color(DividerColor::BorderFaded)) .child(Divider::horizontal().color(DividerColor::BorderFaded))
.child(self.render_agent_server( .child(self.render_agent_server(
AgentIcon::Name(IconName::AiOpenAi), AgentIcon::Name(IconName::AiOpenAi),
"Codex", "Codex CLI",
false, false,
)) ))
.child(Divider::horizontal().color(DividerColor::BorderFaded)) .child(Divider::horizontal().color(DividerColor::BorderFaded))
crates/agent_ui/src/agent_panel.rs
+10 -5
View File
@@ -1880,7 +1880,12 @@ impl AgentPanel {
{ {
let focus_handle = focus_handle.clone(); let focus_handle = focus_handle.clone();
move |_window, cx| { move |_window, cx| {
Tooltip::for_action_in("New…", &ToggleNewThreadMenu, &focus_handle, cx) Tooltip::for_action_in(
"New Thread…",
&ToggleNewThreadMenu,
&focus_handle,
cx,
)
} }
}, },
) )
@@ -1978,7 +1983,7 @@ impl AgentPanel {
.separator() .separator()
.header("External Agents") .header("External Agents")
.item( .item(
ContextMenuEntry::new("New Claude Code Thread") ContextMenuEntry::new("New Claude Code")
.icon(IconName::AiClaude) .icon(IconName::AiClaude)
.disabled(is_via_collab) .disabled(is_via_collab)
.icon_color(Color::Muted) .icon_color(Color::Muted)
@@ -2004,7 +2009,7 @@ impl AgentPanel {
}), }),
) )
.item( .item(
ContextMenuEntry::new("New Codex Thread") ContextMenuEntry::new("New Codex CLI")
.icon(IconName::AiOpenAi) .icon(IconName::AiOpenAi)
.disabled(is_via_collab) .disabled(is_via_collab)
.icon_color(Color::Muted) .icon_color(Color::Muted)
@@ -2030,7 +2035,7 @@ impl AgentPanel {
}), }),
) )
.item( .item(
ContextMenuEntry::new("New Gemini CLI Thread") ContextMenuEntry::new("New Gemini CLI")
.icon(IconName::AiGemini) .icon(IconName::AiGemini)
.icon_color(Color::Muted) .icon_color(Color::Muted)
.disabled(is_via_collab) .disabled(is_via_collab)
@@ -2074,7 +2079,7 @@ impl AgentPanel {
for agent_name in agent_names { for agent_name in agent_names {
let icon_path = agent_server_store_read.agent_icon(&agent_name); let icon_path = agent_server_store_read.agent_icon(&agent_name);
let mut entry = let mut entry =
ContextMenuEntry::new(format!("New {} Thread", agent_name)); ContextMenuEntry::new(format!("New {}", agent_name));
if let Some(icon_path) = icon_path { if let Some(icon_path) = icon_path {
entry = entry.custom_icon_path(icon_path); entry = entry.custom_icon_path(icon_path);
} else { } else {