Change ToolOutput to ToolView (#11682)

Additionally, the internal `ToolView` trait used by the registry is now
called `InternalToolView`.

This should make it a bit easier to understand that the `ToolView` is
intended for a `gpui::View` (implementing `Render`). It does still feel
like more could be merged here but I think the built tools are now a bit
clearer.

Release Notes:

- N/A
This commit is contained in:
Kyle Kelley
2024-05-10 15:22:09 -07:00
committed by GitHub
parent 5515ba6043
commit c71cfd5da4
5 changed files with 17 additions and 17 deletions
+2 -2
View File
@@ -1,5 +1,5 @@
use anyhow::Result;
use assistant_tooling::{LanguageModelTool, ProjectContext, ToolOutput};
use assistant_tooling::{LanguageModelTool, ProjectContext, ToolView};
use editor::{
display_map::{BlockContext, BlockDisposition, BlockProperties, BlockStyle},
Editor, MultiBuffer,
@@ -230,7 +230,7 @@ impl Render for AnnotationResultView {
}
}
impl ToolOutput for AnnotationResultView {
impl ToolView for AnnotationResultView {
type Input = AnnotationInput;
type SerializedState = Option<String>;
+2 -2
View File
@@ -1,5 +1,5 @@
use anyhow::{anyhow, Result};
use assistant_tooling::{LanguageModelTool, ProjectContext, ToolOutput};
use assistant_tooling::{LanguageModelTool, ProjectContext, ToolView};
use editor::Editor;
use gpui::{prelude::*, Model, Task, View, WeakView};
use project::Project;
@@ -65,7 +65,7 @@ impl Render for CreateBufferView {
}
}
impl ToolOutput for CreateBufferView {
impl ToolView for CreateBufferView {
type Input = CreateBufferInput;
type SerializedState = ();
+2 -2
View File
@@ -1,5 +1,5 @@
use anyhow::Result;
use assistant_tooling::{LanguageModelTool, ToolOutput};
use assistant_tooling::{LanguageModelTool, ToolView};
use collections::BTreeMap;
use file_icons::FileIcons;
use gpui::{prelude::*, AnyElement, Model, Task};
@@ -232,7 +232,7 @@ impl Render for ProjectIndexView {
}
}
impl ToolOutput for ProjectIndexView {
impl ToolView for ProjectIndexView {
type Input = CodebaseQuery;
type SerializedState = SerializedState;