From bef3b80bd458539661eb9cd4a5b366337fd8c826 Mon Sep 17 00:00:00 2001
From: Antonio Scandurra <me@as-cii.com>
Date: Wed, 8 Nov 2023 15:08:54 +0100
Subject: [PATCH] Clear hover background highlights

Co-Authored-By: Piotr <piotr@zed.dev>
---
 crates/editor2/src/element.rs       | 5 +++--
 crates/editor2/src/hover_popover.rs | 3 +--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/crates/editor2/src/element.rs b/crates/editor2/src/element.rs
index fce2634e2b..2e29793670 100644
--- a/crates/editor2/src/element.rs
+++ b/crates/editor2/src/element.rs
@@ -412,12 +412,13 @@ impl EditorElement {
                     );
                 }
             }
+
+            true
         } else {
             update_go_to_definition_link(editor, None, modifiers.command, modifiers.shift, cx);
             hover_at(editor, None, cx);
+            false
         }
-
-        true
     }
 
     fn scroll(
diff --git a/crates/editor2/src/hover_popover.rs b/crates/editor2/src/hover_popover.rs
index bee95994e4..5c8f403d4f 100644
--- a/crates/editor2/src/hover_popover.rs
+++ b/crates/editor2/src/hover_popover.rs
@@ -144,8 +144,7 @@ pub fn hide_hover(editor: &mut Editor, cx: &mut ViewContext<Editor>) -> bool {
     editor.hover_state.info_task = None;
     editor.hover_state.triggered_from = None;
 
-    // todo!()
-    // editor.clear_background_highlights::<HoverState>(cx);
+    editor.clear_background_highlights::<HoverState>(cx);
 
     if did_hide {
         cx.notify();