From bddf827bc1bd004aea1a655f56fb175d42b9b708 Mon Sep 17 00:00:00 2001 From: "Joseph T. Lyons" Date: Wed, 10 Jan 2024 21:02:34 -0500 Subject: [PATCH] Add reminder for the future --- crates/client/src/telemetry.rs | 2 +- crates/client/src/telemetry/event_coalescer.rs | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/crates/client/src/telemetry.rs b/crates/client/src/telemetry.rs index d6be4fad28..628b5292c6 100644 --- a/crates/client/src/telemetry.rs +++ b/crates/client/src/telemetry.rs @@ -204,7 +204,7 @@ impl Telemetry { #[cfg(not(any(test, feature = "test-support")))] fn shutdown_telemetry(self: &Arc) -> impl Future { self.report_app_event("close"); - self.flush_events(); + // TODO: close final edit period and make sure it's sent Task::ready(()) } diff --git a/crates/client/src/telemetry/event_coalescer.rs b/crates/client/src/telemetry/event_coalescer.rs index 6369ebccbc..96c61486b8 100644 --- a/crates/client/src/telemetry/event_coalescer.rs +++ b/crates/client/src/telemetry/event_coalescer.rs @@ -26,6 +26,10 @@ impl EventCoalescer { self.log_event_with_time(Utc::now(), environment) } + // pub fn close_current_period(&mut self) -> Option<(DateTime, DateTime)> { + // self.environment.map(|env| self.log_event(env)).flatten() + // } + fn log_event_with_time( &mut self, log_time: DateTime,