oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reduce amount of foreground tasks spawned on multibuffer/editor updates (#41479)

Browse Source 
When doing a project wide search in zed on windows for `hang`, zed
starts to freeze for a couple seconds ultimately starting to error with
`Not enough quota is available to process this command.` when
dispatching windows messages. The cause for this is that we simply
overload the windows message pump due to the sheer amount of foreground
tasks we spawn when we populate the project search.

This PR is an attempt at reducing this.

Release Notes:

- Reduced hangs and stutters in large project file searches
This commit is contained in:
Lukas Wirth
2025-10-30 17:40:56 +00:00
committed by GitHub
parent 743180342a
commit ac3b232dda
13 changed files with 101 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/search/src/project_search.rs
+18 -12
View File
@@ -322,18 +322,25 @@ impl ProjectSearch {
let mut limit_reached = false;
while let Some(results) = matches.next().await {
let mut buffers_with_ranges = Vec::with_capacity(results.len());
for result in results {
match result {
project::search::SearchResult::Buffer { buffer, ranges } => {
buffers_with_ranges.push((buffer, ranges));
let (buffers_with_ranges, has_reached_limit) = cx
.background_executor()
.spawn(async move {
let mut limit_reached = false;
let mut buffers_with_ranges = Vec::with_capacity(results.len());
for result in results {
match result {
project::search::SearchResult::Buffer { buffer, ranges } => {
buffers_with_ranges.push((buffer, ranges));
}
project::search::SearchResult::LimitReached => {
limit_reached = true;
}
}
}
project::search::SearchResult::LimitReached => {
limit_reached = true;
}
}
}
(buffers_with_ranges, limit_reached)
})
.await;
limit_reached |= has_reached_limit;
let mut new_ranges = project_search
.update(cx, |project_search, cx| {
project_search.excerpts.update(cx, |excerpts, cx| {
@@ -352,7 +359,6 @@ impl ProjectSearch {
})
})
.ok()?;
while let Some(new_ranges) = new_ranges.next().await {
project_search
.update(cx, |project_search, cx| {