Rename ThemeMode to ThemeAppearanceMode (#42279)
There was a TODO in `crates/settings/src/settings_content/theme.rs` to make this rename. This PR is just splitting off this change from https://github.com/zed-industries/zed/pull/40035 to make reviewing that one a bit easier since that PR is a bit more involved than expected. Release Notes: - N/A Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This commit is contained in:
@@ -157,7 +157,7 @@ pub enum ThemeSelection {
|
||||
Dynamic {
|
||||
/// The mode used to determine which theme to use.
|
||||
#[serde(default)]
|
||||
mode: ThemeMode,
|
||||
mode: ThemeAppearanceMode,
|
||||
/// The theme to use for light mode.
|
||||
light: ThemeName,
|
||||
/// The theme to use for dark mode.
|
||||
@@ -186,7 +186,7 @@ pub enum IconThemeSelection {
|
||||
Dynamic {
|
||||
/// The mode used to determine which theme to use.
|
||||
#[serde(default)]
|
||||
mode: ThemeMode,
|
||||
mode: ThemeAppearanceMode,
|
||||
/// The icon theme to use for light mode.
|
||||
light: IconThemeName,
|
||||
/// The icon theme to use for dark mode.
|
||||
@@ -194,7 +194,6 @@ pub enum IconThemeSelection {
|
||||
},
|
||||
}
|
||||
|
||||
// TODO: Rename ThemeMode -> ThemeAppearanceMode
|
||||
/// The mode use to select a theme.
|
||||
///
|
||||
/// `Light` and `Dark` will select their respective themes.
|
||||
@@ -215,7 +214,7 @@ pub enum IconThemeSelection {
|
||||
strum::VariantNames,
|
||||
)]
|
||||
#[serde(rename_all = "snake_case")]
|
||||
pub enum ThemeMode {
|
||||
pub enum ThemeAppearanceMode {
|
||||
/// Use the specified `light` theme.
|
||||
Light,
|
||||
|
||||
|
||||
Reference in New Issue
Block a user