oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not resolve more completion fields (#19021)

Browse Source 
As Zed instantly shows completion items in the completion menu, and the
resolve will cause the details to appear, flickering.
We can safely resolve the `documentation`, `additionalTextEdits` and
`command` fields, the rest should be resolved eagerly for now.

Release Notes:

- Fixed completion menu rendering
This commit is contained in:
Kirill Bulatov
2024-10-10 16:10:18 +03:00
committed by GitHub
parent 972886c29e
commit 9bc4e3b4ae
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/lsp/src/lsp.rs
-4
View File
@@ -626,11 +626,7 @@ impl LanguageServer {
properties: vec![ properties: vec![
"additionalTextEdits".to_string(), "additionalTextEdits".to_string(),
"command".to_string(), "command".to_string(),
"detail".to_string(),
"documentation".to_string(), "documentation".to_string(),
"filterText".to_string(),
"labelDetails".to_string(),
"tags".to_string(),
// NB: Do not have this resolved, otherwise Zed becomes slow to complete things // NB: Do not have this resolved, otherwise Zed becomes slow to complete things
// "textEdit".to_string(), // "textEdit".to_string(),
], ],