Implement final move, link, unlink db APIs

crates/channel/src/channel_store.rs

@@ -346,7 +346,7 @@ impl ChannelStore {
     pub fn unlink_channel(
         &mut self,
         channel_id: ChannelId,
-        from: Option<ChannelId>,
+        from: ChannelId,
         cx: &mut ModelContext<Self>,
     ) -> Task<Result<()>> {
         let client = self.client.clone();
@@ -362,7 +362,7 @@ impl ChannelStore {
     pub fn move_channel(
         &mut self,
         channel_id: ChannelId,
-        from: Option<ChannelId>,
+        from: ChannelId,
         to: ChannelId,
         cx: &mut ModelContext<Self>,
     ) -> Task<Result<()>> {

crates/channel/src/channel_store/channel_index.rs

@@ -62,16 +62,13 @@ impl ChannelIndex {
 
     /// Remove the given edge from this index. This will not remove the channel.
     /// If this operation would result in a dangling edge, re-insert it.
-    pub fn delete_edge(&mut self, parent_id: Option<ChannelId>, channel_id: ChannelId) {
-        if let Some(parent_id) = parent_id {
-            self.paths.retain(|path| {
-                !path
-                    .windows(2)
-                    .any(|window| window == [parent_id, channel_id])
-            });
-        } else {
-            self.paths.retain(|path| path.first() != Some(&channel_id));
-        }
+    pub fn delete_edge(&mut self, parent_id: ChannelId, channel_id: ChannelId) {
+        self.paths.retain(|path| {
+            !path
+                .windows(2)
+                .any(|window| window == [parent_id, channel_id])
+        });
+
 
         // Ensure that there is at least one channel path in the index
         if !self