Enable clippy::clone_on_copy (#8728)

This PR enables the
[`clippy::clone_on_copy`](https://rust-lang.github.io/rust-clippy/master/index.html#/clone_on_copy)
rule and fixes the outstanding violations.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers
2024-03-02 17:37:48 -05:00
committed by GitHub
parent 5935681c5c
commit 9735912965
42 changed files with 144 additions and 160 deletions
+2 -2
View File
@@ -294,7 +294,7 @@ mod test {
lsp::CompletionItem {
label: "first".to_string(),
text_edit: Some(lsp::CompletionTextEdit::Edit(lsp::TextEdit {
range: lsp::Range::new(position.clone(), position.clone()),
range: lsp::Range::new(position, position),
new_text: "first".to_string(),
})),
..Default::default()
@@ -302,7 +302,7 @@ mod test {
lsp::CompletionItem {
label: "second".to_string(),
text_edit: Some(lsp::CompletionTextEdit::Edit(lsp::TextEdit {
range: lsp::Range::new(position.clone(), position.clone()),
range: lsp::Range::new(position, position),
new_text: "second".to_string(),
})),
..Default::default()
+1 -1
View File
@@ -90,7 +90,7 @@ impl VimTestContext {
T: 'static,
F: FnOnce(&mut T, &mut ViewContext<T>) -> R + 'static,
{
let window = self.window.clone();
let window = self.window;
self.update_window(window, move |_, cx| view.update(cx, update))
.unwrap()
}
+1 -1
View File
@@ -222,7 +222,7 @@ pub fn visual_block_motion(
start: start.to_point(map),
end: end.to_point(map),
reversed: is_reversed,
goal: goal.clone(),
goal,
};
selections.push(selection);