Enable clippy::clone_on_copy (#8728)
This PR enables the [`clippy::clone_on_copy`](https://rust-lang.github.io/rust-clippy/master/index.html#/clone_on_copy) rule and fixes the outstanding violations. Release Notes: - N/A
This commit is contained in:
@@ -294,7 +294,7 @@ mod test {
|
||||
lsp::CompletionItem {
|
||||
label: "first".to_string(),
|
||||
text_edit: Some(lsp::CompletionTextEdit::Edit(lsp::TextEdit {
|
||||
range: lsp::Range::new(position.clone(), position.clone()),
|
||||
range: lsp::Range::new(position, position),
|
||||
new_text: "first".to_string(),
|
||||
})),
|
||||
..Default::default()
|
||||
@@ -302,7 +302,7 @@ mod test {
|
||||
lsp::CompletionItem {
|
||||
label: "second".to_string(),
|
||||
text_edit: Some(lsp::CompletionTextEdit::Edit(lsp::TextEdit {
|
||||
range: lsp::Range::new(position.clone(), position.clone()),
|
||||
range: lsp::Range::new(position, position),
|
||||
new_text: "second".to_string(),
|
||||
})),
|
||||
..Default::default()
|
||||
|
||||
@@ -90,7 +90,7 @@ impl VimTestContext {
|
||||
T: 'static,
|
||||
F: FnOnce(&mut T, &mut ViewContext<T>) -> R + 'static,
|
||||
{
|
||||
let window = self.window.clone();
|
||||
let window = self.window;
|
||||
self.update_window(window, move |_, cx| view.update(cx, update))
|
||||
.unwrap()
|
||||
}
|
||||
|
||||
@@ -222,7 +222,7 @@ pub fn visual_block_motion(
|
||||
start: start.to_point(map),
|
||||
end: end.to_point(map),
|
||||
reversed: is_reversed,
|
||||
goal: goal.clone(),
|
||||
goal,
|
||||
};
|
||||
|
||||
selections.push(selection);
|
||||
|
||||
Reference in New Issue
Block a user