oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't apply completion's edit when it wouldn't change the buffer

Browse Source 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
This commit is contained in:
Antonio Scandurra
2022-02-02 18:00:30 +01:00
co-authored by Nathan Sobo
parent 924eb622ae
commit 8d7815456c
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/editor/src/editor.rs
+8 -5
View File
@@ -1675,11 +1675,14 @@ impl Editor {
.log_err();
} else {
self.buffer.update(cx, |buffer, cx| {
buffer.edit_with_autoindent(
[completion.old_range.clone()],
&completion.new_text,
cx,
);
let snapshot = buffer.read(cx);
let old_range = completion.old_range.to_offset(&snapshot);
if old_range.len() != completion.new_text.len()
|| !snapshot.contains_str_at(old_range.start, &completion.new_text)
{
drop(snapshot);
buffer.edit_with_autoindent([old_range], &completion.new_text, cx);
}
});
}