One big cleanup pass of clippy lints

Co-authored-by: Mikayla <mikayla@zed.dev>

crates/gpui/src/elements/empty.rs

@@ -11,13 +11,14 @@ use crate::{
 };
 use crate::{Element, Event, EventContext, LayoutContext, PaintContext, SizeConstraint};
 
+#[derive(Default)]
 pub struct Empty {
     collapsed: bool,
 }
 
 impl Empty {
     pub fn new() -> Self {
-        Self { collapsed: false }
+        Self::default()
     }
 
     pub fn collapsed(mut self) -> Self {

crates/gpui/src/elements/expanded.rs

@@ -24,13 +24,13 @@ impl Expanded {
         }
     }
 
-    pub fn to_full_width(mut self) -> Self {
+    pub fn full_width(mut self) -> Self {
         self.full_width = true;
         self.full_height = false;
         self
     }
 
-    pub fn to_full_height(mut self) -> Self {
+    pub fn full_height(mut self) -> Self {
         self.full_width = false;
         self.full_height = true;
         self

crates/gpui/src/elements/image.rs

@@ -53,8 +53,8 @@ impl Element for Image {
         _: &mut LayoutContext,
     ) -> (Vector2F, Self::LayoutState) {
         let desired_size = vec2f(
-            self.style.width.unwrap_or(constraint.max.x()),
-            self.style.height.unwrap_or(constraint.max.y()),
+            self.style.width.unwrap_or_else(|| constraint.max.x()),
+            self.style.height.unwrap_or_else(|| constraint.max.y()),
         );
         let size = constrain_size_preserving_aspect_ratio(
             constraint.constrain(desired_size),

crates/gpui/src/elements/list.rs

@@ -33,6 +33,7 @@ struct StateInner {
     logical_scroll_top: Option<ListOffset>,
     orientation: Orientation,
     overdraw: f32,
+    #[allow(clippy::type_complexity)]
     scroll_handler: Option<Box<dyn FnMut(Range<usize>, &mut EventContext)>>,
 }
 
@@ -311,19 +312,17 @@ impl Element for List {
         drop(cursor);
         state.items = new_items;
 
-        match event {
-            Event::ScrollWheel(ScrollWheelEvent {
-                position,
-                delta,
-                precise,
-            }) => {
-                if bounds.contains_point(*position) {
-                    if state.scroll(scroll_top, bounds.height(), *delta, *precise, cx) {
-                        handled = true;
-                    }
-                }
+        if let Event::ScrollWheel(ScrollWheelEvent {
+            position,
+            delta,
+            precise,
+        }) = event
+        {
+            if bounds.contains_point(*position)
+                && state.scroll(scroll_top, bounds.height(), *delta, *precise, cx)
+            {
+                handled = true;
             }
-            _ => {}
         }
 
         handled

crates/gpui/src/elements/mouse_event_handler.rs

@@ -129,7 +129,7 @@ impl Element for MouseEventHandler {
 
         cx.scene.push_mouse_region(MouseRegion::from_handlers(
             cx.current_view_id(),
-            Some(self.discriminant.clone()),
+            Some(self.discriminant),
             hit_bounds,
             self.handlers.clone(),
         ));

crates/gpui/src/elements/overlay.rs

@@ -74,7 +74,7 @@ impl Element for Overlay {
         size: &mut Self::LayoutState,
         cx: &mut PaintContext,
     ) {
-        let mut bounds = RectF::new(self.abs_position.unwrap_or(bounds.origin()), *size);
+        let mut bounds = RectF::new(self.abs_position.unwrap_or_else(|| bounds.origin()), *size);
         cx.scene.push_stacking_context(None);
 
         if self.hoverable {

crates/gpui/src/elements/stack.rs

@@ -8,15 +8,14 @@ use crate::{
     SizeConstraint,
 };
 
+#[derive(Default)]
 pub struct Stack {
     children: Vec<ElementBox>,
 }
 
 impl Stack {
     pub fn new() -> Self {
-        Stack {
-            children: Vec::new(),
-        }
+        Self::default()
     }
 }
 

crates/gpui/src/elements/text.rs

@@ -100,7 +100,7 @@ impl Element for Text {
             chunks,
             &self.style,
             cx.text_layout_cache,
-            &cx.font_cache,
+            cx.font_cache,
             usize::MAX,
             self.text.matches('\n').count() + 1,
         );

crates/gpui/src/elements/uniform_list.rs

@@ -45,6 +45,7 @@ pub struct LayoutState {
 pub struct UniformList {
     state: UniformListState,
     item_count: usize,
+    #[allow(clippy::type_complexity)]
     append_items: Box<dyn Fn(Range<usize>, &mut Vec<ElementBox>, &mut LayoutContext)>,
     padding_top: f32,
     padding_bottom: f32,
@@ -310,19 +311,17 @@ impl Element for UniformList {
             handled = item.dispatch_event(event, cx) || handled;
         }
 
-        match event {
-            Event::ScrollWheel(ScrollWheelEvent {
-                position,
-                delta,
-                precise,
-            }) => {
-                if bounds.contains_point(*position) {
-                    if self.scroll(*position, *delta, *precise, layout.scroll_max, cx) {
-                        handled = true;
-                    }
-                }
+        if let Event::ScrollWheel(ScrollWheelEvent {
+            position,
+            delta,
+            precise,
+        }) = event
+        {
+            if bounds.contains_point(*position)
+                && self.scroll(*position, *delta, *precise, layout.scroll_max, cx)
+            {
+                handled = true;
             }
-            _ => {}
         }
 
         handled