Simplify error management in stream_completion (#43035)
This PR simplifies error and event handling by removing the `Ok(LanguageModelCompletionEvent::Status(CompletionRequestStatus::Failed)))` state from the stream returned by `LanguageModel::stream_completion()`, by changing it into an `Err(LanguageModelCompletionError)`. This was done by collapsing the valid `CompletionRequestStatus` values into `LanguageModelCompletionEvent`. Release Notes: - N/A --------- Co-authored-by: Michael Benfield <mbenfield@zed.dev>
This commit is contained in:
co-authored by
Michael Benfield
parent
659169f06d
commit
898c133906
@@ -1251,8 +1251,11 @@ pub fn response_events_to_markdown(
|
||||
}
|
||||
Ok(
|
||||
LanguageModelCompletionEvent::UsageUpdate(_)
|
||||
| LanguageModelCompletionEvent::ToolUseLimitReached
|
||||
| LanguageModelCompletionEvent::StartMessage { .. }
|
||||
| LanguageModelCompletionEvent::StatusUpdate { .. },
|
||||
| LanguageModelCompletionEvent::UsageUpdated { .. }
|
||||
| LanguageModelCompletionEvent::Queued { .. }
|
||||
| LanguageModelCompletionEvent::Started,
|
||||
) => {}
|
||||
Ok(LanguageModelCompletionEvent::ToolUseJsonParseError {
|
||||
json_parse_error, ..
|
||||
@@ -1337,9 +1340,12 @@ impl ThreadDialog {
|
||||
// Skip these
|
||||
Ok(LanguageModelCompletionEvent::UsageUpdate(_))
|
||||
| Ok(LanguageModelCompletionEvent::RedactedThinking { .. })
|
||||
| Ok(LanguageModelCompletionEvent::StatusUpdate { .. })
|
||||
| Ok(LanguageModelCompletionEvent::StartMessage { .. })
|
||||
| Ok(LanguageModelCompletionEvent::Stop(_)) => {}
|
||||
| Ok(LanguageModelCompletionEvent::Stop(_))
|
||||
| Ok(LanguageModelCompletionEvent::Queued { .. })
|
||||
| Ok(LanguageModelCompletionEvent::Started)
|
||||
| Ok(LanguageModelCompletionEvent::UsageUpdated { .. })
|
||||
| Ok(LanguageModelCompletionEvent::ToolUseLimitReached) => {}
|
||||
|
||||
Ok(LanguageModelCompletionEvent::ToolUseJsonParseError {
|
||||
json_parse_error,
|
||||
|
||||
Reference in New Issue
Block a user