Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -480,7 +480,7 @@ impl Pane {
|
||||
forward_stack: Default::default(),
|
||||
closed_stack: Default::default(),
|
||||
paths_by_item: Default::default(),
|
||||
pane: handle.clone(),
|
||||
pane: handle,
|
||||
next_timestamp,
|
||||
}))),
|
||||
toolbar: cx.new(|_| Toolbar::new()),
|
||||
@@ -2516,7 +2516,7 @@ impl Pane {
|
||||
this.handle_external_paths_drop(paths, window, cx)
|
||||
}))
|
||||
.when_some(item.tab_tooltip_content(cx), |tab, content| match content {
|
||||
TabTooltipContent::Text(text) => tab.tooltip(Tooltip::text(text.clone())),
|
||||
TabTooltipContent::Text(text) => tab.tooltip(Tooltip::text(text)),
|
||||
TabTooltipContent::Custom(element_fn) => {
|
||||
tab.tooltip(move |window, cx| element_fn(window, cx))
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user