Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -474,8 +474,7 @@ mod test {
|
||||
Mode::Normal,
|
||||
);
|
||||
assert_eq!(
|
||||
cx.read_from_clipboard()
|
||||
.map(|item| item.text().unwrap().to_string()),
|
||||
cx.read_from_clipboard().map(|item| item.text().unwrap()),
|
||||
Some("jumps".into())
|
||||
);
|
||||
cx.simulate_keystrokes("d d p");
|
||||
@@ -487,8 +486,7 @@ mod test {
|
||||
Mode::Normal,
|
||||
);
|
||||
assert_eq!(
|
||||
cx.read_from_clipboard()
|
||||
.map(|item| item.text().unwrap().to_string()),
|
||||
cx.read_from_clipboard().map(|item| item.text().unwrap()),
|
||||
Some("jumps".into())
|
||||
);
|
||||
cx.write_to_clipboard(ClipboardItem::new_string("test-copy".to_string()));
|
||||
|
||||
Reference in New Issue
Block a user