Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -257,9 +257,9 @@ pub fn refine_theme_family(theme_family_content: ThemeFamilyContent) -> ThemeFam
|
||||
let author = theme_family_content.author.clone();
|
||||
|
||||
let mut theme_family = ThemeFamily {
|
||||
id: id.clone(),
|
||||
name: name.clone().into(),
|
||||
author: author.clone().into(),
|
||||
id,
|
||||
name: name.into(),
|
||||
author: author.into(),
|
||||
themes: vec![],
|
||||
scales: default_color_scales(),
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user