Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -361,7 +361,7 @@ pub fn replace_top_level_array_value_in_json_text(
|
||||
let needs_indent = range.start_point.row > 0;
|
||||
|
||||
if new_value.is_none() && key_path.is_empty() {
|
||||
let mut remove_range = text_range.clone();
|
||||
let mut remove_range = text_range;
|
||||
if index == 0 {
|
||||
while cursor.goto_next_sibling()
|
||||
&& (cursor.node().is_extra() || cursor.node().is_missing())
|
||||
@@ -582,7 +582,7 @@ mod tests {
|
||||
expected: String,
|
||||
) {
|
||||
let result = replace_value_in_json_text(&input, key_path, 4, value.as_ref(), None);
|
||||
let mut result_str = input.to_string();
|
||||
let mut result_str = input;
|
||||
result_str.replace_range(result.0, &result.1);
|
||||
pretty_assertions::assert_eq!(expected, result_str);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user