Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -716,10 +716,10 @@ impl BufferSearchBar {
|
||||
self.replace_enabled = deploy.replace_enabled;
|
||||
self.selection_search_enabled = deploy.selection_search_enabled;
|
||||
if deploy.focus {
|
||||
let mut handle = self.query_editor.focus_handle(cx).clone();
|
||||
let mut handle = self.query_editor.focus_handle(cx);
|
||||
let mut select_query = true;
|
||||
if deploy.replace_enabled && handle.is_focused(window) {
|
||||
handle = self.replacement_editor.focus_handle(cx).clone();
|
||||
handle = self.replacement_editor.focus_handle(cx);
|
||||
select_query = false;
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user