Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -187,7 +187,7 @@ impl PickerDelegate for KernelPickerDelegate {
|
||||
.size(LabelSize::Default),
|
||||
),
|
||||
)
|
||||
.when_some(path_or_url.clone(), |flex, path| {
|
||||
.when_some(path_or_url, |flex, path| {
|
||||
flex.text_ellipsis().child(
|
||||
Label::new(path)
|
||||
.size(LabelSize::Small)
|
||||
|
||||
Reference in New Issue
Block a user