Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -457,7 +457,7 @@ impl WorktreeStore {
|
||||
})
|
||||
.collect::<HashMap<_, _>>();
|
||||
|
||||
let (client, project_id) = self.upstream_client().clone().context("invalid project")?;
|
||||
let (client, project_id) = self.upstream_client().context("invalid project")?;
|
||||
|
||||
for worktree in worktrees {
|
||||
if let Some(old_worktree) =
|
||||
|
||||
Reference in New Issue
Block a user