Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -760,7 +760,7 @@ impl Inventory {
|
||||
TaskSettingsLocation::Global(path) => {
|
||||
previously_existing_scenarios = parsed_scenarios
|
||||
.global_scenarios()
|
||||
.map(|(_, scenario)| scenario.label.clone())
|
||||
.map(|(_, scenario)| scenario.label)
|
||||
.collect::<HashSet<_>>();
|
||||
parsed_scenarios
|
||||
.global
|
||||
@@ -770,7 +770,7 @@ impl Inventory {
|
||||
TaskSettingsLocation::Worktree(location) => {
|
||||
previously_existing_scenarios = parsed_scenarios
|
||||
.worktree_scenarios(location.worktree_id)
|
||||
.map(|(_, scenario)| scenario.label.clone())
|
||||
.map(|(_, scenario)| scenario.label)
|
||||
.collect::<HashSet<_>>();
|
||||
|
||||
if new_templates.is_empty() {
|
||||
|
||||
Reference in New Issue
Block a user