Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -52,7 +52,7 @@ impl RenderOnce for PanelTab {
|
||||
|
||||
pub fn panel_button(label: impl Into<SharedString>) -> ui::Button {
|
||||
let label = label.into();
|
||||
let id = ElementId::Name(label.clone().to_lowercase().replace(' ', "_").into());
|
||||
let id = ElementId::Name(label.to_lowercase().replace(' ', "_").into());
|
||||
ui::Button::new(id, label)
|
||||
.label_size(ui::LabelSize::Small)
|
||||
.icon_size(ui::IconSize::Small)
|
||||
|
||||
Reference in New Issue
Block a user