Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -178,7 +178,6 @@ impl<'a> MarkdownParser<'a> {
|
||||
_ => None,
|
||||
},
|
||||
Event::Rule => {
|
||||
let source_range = source_range.clone();
|
||||
self.cursor += 1;
|
||||
Some(vec![ParsedMarkdownElement::HorizontalRule(source_range)])
|
||||
}
|
||||
@@ -401,7 +400,7 @@ impl<'a> MarkdownParser<'a> {
|
||||
}
|
||||
if !text.is_empty() {
|
||||
markdown_text_like.push(MarkdownParagraphChunk::Text(ParsedMarkdownText {
|
||||
source_range: source_range.clone(),
|
||||
source_range,
|
||||
contents: text,
|
||||
highlights,
|
||||
regions,
|
||||
@@ -420,7 +419,7 @@ impl<'a> MarkdownParser<'a> {
|
||||
self.cursor += 1;
|
||||
|
||||
ParsedMarkdownHeading {
|
||||
source_range: source_range.clone(),
|
||||
source_range,
|
||||
level: match level {
|
||||
pulldown_cmark::HeadingLevel::H1 => HeadingLevel::H1,
|
||||
pulldown_cmark::HeadingLevel::H2 => HeadingLevel::H2,
|
||||
|
||||
@@ -115,8 +115,7 @@ impl MarkdownPreviewView {
|
||||
pane.activate_item(existing_follow_view_idx, true, true, window, cx);
|
||||
});
|
||||
} else {
|
||||
let view =
|
||||
Self::create_following_markdown_view(workspace, editor.clone(), window, cx);
|
||||
let view = Self::create_following_markdown_view(workspace, editor, window, cx);
|
||||
workspace.active_pane().update(cx, |pane, cx| {
|
||||
pane.add_item(Box::new(view.clone()), true, true, None, window, cx)
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user