Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -117,7 +117,6 @@ impl AudioStack {
|
||||
|
||||
let (frame_tx, mut frame_rx) = futures::channel::mpsc::unbounded();
|
||||
let transmit_task = self.executor.spawn({
|
||||
let source = source.clone();
|
||||
async move {
|
||||
while let Some(frame) = frame_rx.next().await {
|
||||
source.capture_frame(&frame).await.log_err();
|
||||
@@ -132,12 +131,12 @@ impl AudioStack {
|
||||
drop(transmit_task);
|
||||
drop(capture_task);
|
||||
});
|
||||
return Ok((
|
||||
Ok((
|
||||
super::LocalAudioTrack(track),
|
||||
AudioStream::Output {
|
||||
_drop: Box::new(on_drop),
|
||||
},
|
||||
));
|
||||
))
|
||||
}
|
||||
|
||||
fn start_output(&self) -> Arc<Task<()>> {
|
||||
|
||||
Reference in New Issue
Block a user