Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -22,7 +22,7 @@ impl CLspAdapter {
|
||||
#[async_trait(?Send)]
|
||||
impl super::LspAdapter for CLspAdapter {
|
||||
fn name(&self) -> LanguageServerName {
|
||||
Self::SERVER_NAME.clone()
|
||||
Self::SERVER_NAME
|
||||
}
|
||||
|
||||
async fn check_if_user_installed(
|
||||
@@ -253,8 +253,7 @@ impl super::LspAdapter for CLspAdapter {
|
||||
.grammar()
|
||||
.and_then(|g| g.highlight_id_for_name(highlight_name?))
|
||||
{
|
||||
let mut label =
|
||||
CodeLabel::plain(label.to_string(), completion.filter_text.as_deref());
|
||||
let mut label = CodeLabel::plain(label, completion.filter_text.as_deref());
|
||||
label.runs.push((
|
||||
0..label.text.rfind('(').unwrap_or(label.text.len()),
|
||||
highlight_id,
|
||||
@@ -264,10 +263,7 @@ impl super::LspAdapter for CLspAdapter {
|
||||
}
|
||||
_ => {}
|
||||
}
|
||||
Some(CodeLabel::plain(
|
||||
label.to_string(),
|
||||
completion.filter_text.as_deref(),
|
||||
))
|
||||
Some(CodeLabel::plain(label, completion.filter_text.as_deref()))
|
||||
}
|
||||
|
||||
async fn label_for_symbol(
|
||||
|
||||
Reference in New Issue
Block a user