Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -140,7 +140,7 @@ impl State {
|
||||
Self {
|
||||
client: client.clone(),
|
||||
llm_api_token: LlmApiToken::default(),
|
||||
user_store: user_store.clone(),
|
||||
user_store,
|
||||
status,
|
||||
accept_terms_of_service_task: None,
|
||||
models: Vec::new(),
|
||||
@@ -307,7 +307,7 @@ impl CloudLanguageModelProvider {
|
||||
|
||||
Self {
|
||||
client,
|
||||
state: state.clone(),
|
||||
state,
|
||||
_maintain_client_status: maintain_client_status,
|
||||
}
|
||||
}
|
||||
@@ -320,7 +320,7 @@ impl CloudLanguageModelProvider {
|
||||
Arc::new(CloudLanguageModel {
|
||||
id: LanguageModelId(SharedString::from(model.id.0.clone())),
|
||||
model,
|
||||
llm_api_token: llm_api_token.clone(),
|
||||
llm_api_token,
|
||||
client: self.client.clone(),
|
||||
request_limiter: RateLimiter::new(4),
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user