Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -668,11 +668,7 @@ mod tests {
|
||||
let contexts = vec![other_context.clone(), child_context.clone()];
|
||||
assert!(!predicate.eval(&contexts));
|
||||
|
||||
let contexts = vec![
|
||||
parent_context.clone(),
|
||||
other_context.clone(),
|
||||
child_context.clone(),
|
||||
];
|
||||
let contexts = vec![parent_context.clone(), other_context, child_context.clone()];
|
||||
assert!(predicate.eval(&contexts));
|
||||
|
||||
assert!(!predicate.eval(&[]));
|
||||
@@ -681,7 +677,7 @@ mod tests {
|
||||
|
||||
let zany_predicate = KeyBindingContextPredicate::parse("child > child").unwrap();
|
||||
assert!(!zany_predicate.eval(slice::from_ref(&child_context)));
|
||||
assert!(zany_predicate.eval(&[child_context.clone(), child_context.clone()]));
|
||||
assert!(zany_predicate.eval(&[child_context.clone(), child_context]));
|
||||
}
|
||||
|
||||
#[test]
|
||||
@@ -718,7 +714,7 @@ mod tests {
|
||||
let not_descendant = KeyBindingContextPredicate::parse("parent > !child").unwrap();
|
||||
assert!(!not_descendant.eval(slice::from_ref(&parent_context)));
|
||||
assert!(!not_descendant.eval(slice::from_ref(&child_context)));
|
||||
assert!(!not_descendant.eval(&[parent_context.clone(), child_context.clone()]));
|
||||
assert!(!not_descendant.eval(&[parent_context, child_context]));
|
||||
|
||||
let double_not = KeyBindingContextPredicate::parse("!!editor").unwrap();
|
||||
assert!(double_not.eval(slice::from_ref(&editor_context)));
|
||||
|
||||
Reference in New Issue
Block a user