Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -1330,7 +1330,6 @@ async fn test_unsetting_breakpoints_on_clear_breakpoint_action(
|
||||
let called_set_breakpoints = Arc::new(AtomicBool::new(false));
|
||||
|
||||
client.on_request::<SetBreakpoints, _>({
|
||||
let called_set_breakpoints = called_set_breakpoints.clone();
|
||||
move |_, args| {
|
||||
assert!(
|
||||
args.breakpoints.is_none_or(|bps| bps.is_empty()),
|
||||
@@ -1445,7 +1444,6 @@ async fn test_we_send_arguments_from_user_config(
|
||||
let launch_handler_called = Arc::new(AtomicBool::new(false));
|
||||
|
||||
start_debug_session_with(&workspace, cx, debug_definition.clone(), {
|
||||
let debug_definition = debug_definition.clone();
|
||||
let launch_handler_called = launch_handler_called.clone();
|
||||
|
||||
move |client| {
|
||||
@@ -1783,9 +1781,8 @@ async fn test_debug_adapters_shutdown_on_app_quit(
|
||||
let disconnect_request_received = Arc::new(AtomicBool::new(false));
|
||||
let disconnect_clone = disconnect_request_received.clone();
|
||||
|
||||
let disconnect_clone_for_handler = disconnect_clone.clone();
|
||||
client.on_request::<Disconnect, _>(move |_, _| {
|
||||
disconnect_clone_for_handler.store(true, Ordering::SeqCst);
|
||||
disconnect_clone.store(true, Ordering::SeqCst);
|
||||
Ok(())
|
||||
});
|
||||
|
||||
|
||||
@@ -106,9 +106,7 @@ async fn test_debug_session_substitutes_variables_and_relativizes_paths(
|
||||
);
|
||||
|
||||
let expected_other_field = if input_path.contains("$ZED_WORKTREE_ROOT") {
|
||||
input_path
|
||||
.replace("$ZED_WORKTREE_ROOT", path!("/test/worktree/path"))
|
||||
.to_owned()
|
||||
input_path.replace("$ZED_WORKTREE_ROOT", path!("/test/worktree/path"))
|
||||
} else {
|
||||
input_path.to_string()
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user