Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
@@ -664,7 +664,7 @@ impl ToolbarItemView for DapLogToolbarItemView {
|
||||
if let Some(item) = active_pane_item
|
||||
&& let Some(log_view) = item.downcast::<DapLogView>()
|
||||
{
|
||||
self.log_view = Some(log_view.clone());
|
||||
self.log_view = Some(log_view);
|
||||
return workspace::ToolbarItemLocation::PrimaryLeft;
|
||||
}
|
||||
self.log_view = None;
|
||||
|
||||
Reference in New Issue
Block a user