Save buffers after restoring hunks in the project diff (#25620)

This PR fixes a bug where using the project diff editor to restore hunks
from a file that's not open in its own buffer would cause those reverts
to be lost once the project diff drops its excerpts for that file.

The fix is to save the buffers after restoring them but before the
excerpts are (potentially) dropped. This is done for the project diff
editor only. If we fail to save the affected files, we add their buffers
to the active workspace, so that the reverted contents are preserved and
the user can try again to save them.

- [x] Get it working
- [x] Test
- [ ] ~~Clean up boolean soup~~

Co-authored-by: Max <max@zed.dev>

Release Notes:

- N/A
This commit is contained in:
Cole Miller
2025-02-26 15:16:17 -05:00
committed by GitHub
co-authored by Max
parent add7ae8052
commit 7a34dd9888
10 changed files with 195 additions and 19 deletions
+6 -1
View File
@@ -1499,6 +1499,7 @@ impl Workspace {
project_entry_id,
true,
entry.is_preview,
true,
None,
window, cx,
build_item,
@@ -2801,15 +2802,17 @@ impl Workspace {
window: &mut Window,
cx: &mut App,
) -> Task<Result<Box<dyn ItemHandle>, anyhow::Error>> {
self.open_path_preview(path, pane, focus_item, false, window, cx)
self.open_path_preview(path, pane, focus_item, false, true, window, cx)
}
#[allow(clippy::too_many_arguments)]
pub fn open_path_preview(
&mut self,
path: impl Into<ProjectPath>,
pane: Option<WeakEntity<Pane>>,
focus_item: bool,
allow_preview: bool,
activate: bool,
window: &mut Window,
cx: &mut App,
) -> Task<Result<Box<dyn ItemHandle>, anyhow::Error>> {
@@ -2830,6 +2833,7 @@ impl Workspace {
project_entry_id,
focus_item,
allow_preview,
activate,
None,
window,
cx,
@@ -2888,6 +2892,7 @@ impl Workspace {
project_entry_id,
true,
allow_preview,
true,
None,
window,
cx,