oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use into_owned over to_string for Cow<str> (#39024)

Browse Source 
This removes unnecessary allocations when the `Cow` is already owned


Release Notes:

- N/A *or* Added/Fixed/Improved ...
This commit is contained in:
Lukas Wirth
2025-09-27 14:50:10 +00:00
committed by GitHub
parent a063a70cfb
commit 72948e14ee
84 changed files with 169 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/worktree/src/worktree.rs
+5 -5
View File
@@ -622,7 +622,7 @@ impl Worktree {
id: self.id().to_proto(),
root_name: self.root_name().to_proto(),
visible: self.is_visible(),
abs_path: self.abs_path().to_string_lossy().to_string(),
abs_path: self.abs_path().to_string_lossy().into_owned(),
}
}
@@ -982,7 +982,7 @@ impl Worktree {
.join("~", &*stripped.to_string_lossy())
.unwrap()
} else {
full_path.to_string_lossy().to_string()
full_path.to_string_lossy().into_owned()
};
if worktree_relative_path.components().next().is_some() {
@@ -2072,7 +2072,7 @@ impl Snapshot {
proto::UpdateWorktree {
project_id,
worktree_id,
abs_path: self.abs_path().to_string_lossy().to_string(),
abs_path: self.abs_path().to_string_lossy().into_owned(),
root_name: self.root_name().to_proto(),
updated_entries,
removed_entries: Vec::new(),
@@ -2415,7 +2415,7 @@ impl LocalSnapshot {
proto::UpdateWorktree {
project_id,
worktree_id,
abs_path: self.abs_path().to_string_lossy().to_string(),
abs_path: self.abs_path().to_string_lossy().into_owned(),
root_name: self.root_name().to_proto(),
updated_entries,
removed_entries,
@@ -5354,7 +5354,7 @@ impl<'a> From<&'a Entry> for proto::Entry {
canonical_path: entry
.canonical_path
.as_ref()
.map(|path| path.to_string_lossy().to_string()),
.map(|path| path.to_string_lossy().into_owned()),
}
}
}