oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix project-panel double click file support on Windows (#10917)

Browse Source 
Release Notes:

- Fixed project panel double click to force open file on Windows.

Ref issue: #10898 

@bennetbo 

I saw you was also used `event.down.click_count` in Markdown Preview.


https://github.com/zed-industries/zed/commit/7dccbd8e3b61c48ae174807a4023332b7c1df06a#diff-c8d1735cb347ea08d03198df112343ec50a74de8d50414a6f3be6c6d674c6d19R161

And this also used in other place:

<img width="870" alt="image"
src="https://github.com/zed-industries/zed/assets/5518/b844e700-b95f-4cd2-987f-9e4305ebdd7c">

## Test demo after updated

Looks like it is no side effect

![2024-04-24 10 17
45](https://github.com/zed-industries/zed/assets/5518/0df4cf06-7448-4014-9df2-f2608a5f5314)
This commit is contained in:
Jason Lee
2024-04-25 10:01:24 -07:00
committed by GitHub
parent 0d6fb08b67
commit 7065da2b98
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/gpui/src/platform/windows/window.rs
+2 -1
View File
@@ -701,12 +701,13 @@ impl WindowsWindowInner {
if let Some(callback) = callbacks.input.as_mut() { if let Some(callback) = callbacks.input.as_mut() {
let x = lparam.signed_loword() as f32; let x = lparam.signed_loword() as f32;
let y = lparam.signed_hiword() as f32; let y = lparam.signed_hiword() as f32;
let click_count = self.click_state.borrow().current_count;
let scale_factor = self.scale_factor.get(); let scale_factor = self.scale_factor.get();
let event = MouseUpEvent { let event = MouseUpEvent {
button, button,
position: logical_point(x, y, scale_factor), position: logical_point(x, y, scale_factor),
modifiers: self.current_modifiers(), modifiers: self.current_modifiers(),
click_count: 1, click_count,
}; };
if callback(PlatformInput::MouseUp(event)).default_prevented { if callback(PlatformInput::MouseUp(event)).default_prevented {
return Some(0); return Some(0);