settings ui: Create settings key trait (#37489)
This PR separates out the associated constant `KEY` from the `Settings` trait into a new trait `SettingsKey`. This allows for the key trait to be derived using attributes to specify the path so that the new `SettingsUi` derive macro can use the same attributes to determine top level settings paths thereby removing the need to duplicate the path in both `Settings::KEY` and `#[settings_ui(path = "...")]` Co-authored-by: Ben Kunkle <ben@zed.dev> Release Notes: - N/A --------- Co-authored-by: Ben Kunkle <ben@zed.dev>
This commit is contained in:
co-authored by
Ben Kunkle
parent
223fda2fe2
commit
5f03202b5c
@@ -264,13 +264,9 @@ pub(crate) fn render_ai_setup_page(
|
||||
);
|
||||
|
||||
let fs = <dyn Fs>::global(cx);
|
||||
update_settings_file::<DisableAiSettings>(
|
||||
fs,
|
||||
cx,
|
||||
move |ai_settings: &mut Option<bool>, _| {
|
||||
*ai_settings = Some(enabled);
|
||||
},
|
||||
);
|
||||
update_settings_file::<DisableAiSettings>(fs, cx, move |ai_settings, _| {
|
||||
ai_settings.disable_ai = Some(enabled);
|
||||
});
|
||||
},
|
||||
)
|
||||
.tab_index({
|
||||
|
||||
@@ -388,7 +388,7 @@ fn render_vim_mode_switch(tab_index: &mut isize, cx: &mut App) -> impl IntoEleme
|
||||
}
|
||||
};
|
||||
update_settings_file::<VimModeSetting>(fs.clone(), cx, move |setting, _| {
|
||||
*setting = Some(vim_mode);
|
||||
setting.vim_mode = Some(vim_mode);
|
||||
});
|
||||
|
||||
telemetry::event!(
|
||||
|
||||
Reference in New Issue
Block a user