JSON Schema URIs (#38916)

Closes #ISSUE

Improves the efficiency of our interactions with the Zed language
server. Previously, on startup and after every workspace configuration
changed notification, we would send >1MB of JSON Schemas to the JSON
LSP. The only reason this had to happen was due to the case where an
extension was installed that would result in a change to the JSON schema
for settings (i.e. added language, theme, etc).

This PR changes the behavior to use the URI LSP extensions of
`vscode-json-language-server` in order to send the server URI's that it
can then use to fetch the schemas as needed (i.e. the settings schema is
only generated and sent when `settings.json` is opened. This brings the
JSON we send to on startup and after every workspace configuration
changed notification down to a couple of KB.

Additionally, using another LSP extension request we can notify the
server when a schema has changed using the URI as a key, so we no longer
have to send a workspace configuration changed notification, and the
schema contents will only be re-requested and regenerated if the schema
is in use.

Release Notes:

- Improved the efficiency of communication with the builtin JSON LSP.
JSON Schemas are no longer sent to the JSON language server in their
full form. If you wish to view a builtin JSON schema in the language
server info tab of the language server logs (`dev: open language server
logs`), you must now use the `editor: open url` action with your cursor
over the URL that is sent to the server.
- Made it so that Zed urls (`zed://...`) are resolved locally when
opened within the editor instead of being resolved through the OS. Users
who could not previously open `zed://*` URLs in the editor can now do so
by pasting the link into a buffer and using the `editor: open url`
action (please open an issue if this is the case for you!).

---------

Co-authored-by: Michael <michael@zed.dev>
This commit is contained in:
Ben Kunkle
2025-09-26 11:41:26 -04:00
committed by GitHub
co-authored by Michael
parent 30b49cfbf5
commit 4aac5642c1
28 changed files with 743 additions and 489 deletions
+11 -7
View File
@@ -83,7 +83,7 @@ use aho_corasick::AhoCorasick;
use anyhow::{Context as _, Result, anyhow};
use blink_manager::BlinkManager;
use buffer_diff::DiffHunkStatus;
use client::{Collaborator, ParticipantIndex};
use client::{Collaborator, ParticipantIndex, parse_zed_link};
use clock::{AGENT_REPLICA_ID, ReplicaId};
use code_context_menus::{
AvailableCodeAction, CodeActionContents, CodeActionsItem, CodeActionsMenu, CodeContextMenu,
@@ -16326,7 +16326,7 @@ impl Editor {
None
};
let url_finder = cx.spawn_in(window, async move |editor, cx| {
let url_finder = cx.spawn_in(window, async move |_editor, cx| {
let url = if let Some(end_pos) = end_position {
find_url_from_range(&buffer, start_position..end_pos, cx.clone())
} else {
@@ -16334,12 +16334,16 @@ impl Editor {
};
if let Some(url) = url {
editor.update(cx, |_, cx| {
cx.open_url(&url);
})
} else {
Ok(())
cx.update(|window, cx| {
if parse_zed_link(&url, cx).is_some() {
window.dispatch_action(Box::new(zed_actions::OpenZedUrl { url }), cx);
} else {
cx.open_url(&url);
}
})?;
}
anyhow::Ok(())
});
url_finder.detach();