JSON Schema URIs (#38916)

Closes #ISSUE

Improves the efficiency of our interactions with the Zed language
server. Previously, on startup and after every workspace configuration
changed notification, we would send >1MB of JSON Schemas to the JSON
LSP. The only reason this had to happen was due to the case where an
extension was installed that would result in a change to the JSON schema
for settings (i.e. added language, theme, etc).

This PR changes the behavior to use the URI LSP extensions of
`vscode-json-language-server` in order to send the server URI's that it
can then use to fetch the schemas as needed (i.e. the settings schema is
only generated and sent when `settings.json` is opened. This brings the
JSON we send to on startup and after every workspace configuration
changed notification down to a couple of KB.

Additionally, using another LSP extension request we can notify the
server when a schema has changed using the URI as a key, so we no longer
have to send a workspace configuration changed notification, and the
schema contents will only be re-requested and regenerated if the schema
is in use.

Release Notes:

- Improved the efficiency of communication with the builtin JSON LSP.
JSON Schemas are no longer sent to the JSON language server in their
full form. If you wish to view a builtin JSON schema in the language
server info tab of the language server logs (`dev: open language server
logs`), you must now use the `editor: open url` action with your cursor
over the URL that is sent to the server.
- Made it so that Zed urls (`zed://...`) are resolved locally when
opened within the editor instead of being resolved through the OS. Users
who could not previously open `zed://*` URLs in the editor can now do so
by pasting the link into a buffer and using the `editor: open url`
action (please open an issue if this is the case for you!).

---------

Co-authored-by: Michael <michael@zed.dev>
This commit is contained in:
Ben Kunkle
2025-09-26 11:41:26 -04:00
committed by GitHub
co-authored by Michael
parent 30b49cfbf5
commit 4aac5642c1
28 changed files with 743 additions and 489 deletions
Generated
+27 -4
View File
@@ -8390,6 +8390,28 @@ dependencies = [
"thiserror 1.0.69",
]
[[package]]
name = "json_schema_store"
version = "0.1.0"
dependencies = [
"anyhow",
"dap",
"extension",
"gpui",
"language",
"paths",
"project",
"schemars 1.0.1",
"serde",
"serde_json",
"settings",
"snippet_provider",
"task",
"theme",
"util",
"workspace-hack",
]
[[package]]
name = "jsonschema"
version = "0.30.0"
@@ -8477,6 +8499,7 @@ dependencies = [
"fuzzy",
"gpui",
"itertools 0.14.0",
"json_schema_store",
"language",
"log",
"menu",
@@ -8794,17 +8817,16 @@ dependencies = [
"async-trait",
"chrono",
"collections",
"dap",
"futures 0.3.31",
"gpui",
"http_client",
"itertools 0.14.0",
"json_schema_store",
"language",
"log",
"lsp",
"node_runtime",
"parking_lot",
"paths",
"pet",
"pet-conda",
"pet-core",
@@ -8817,7 +8839,6 @@ dependencies = [
"regex",
"rope",
"rust-embed",
"schemars 1.0.1",
"serde",
"serde_json",
"serde_json_lenient",
@@ -8825,7 +8846,6 @@ dependencies = [
"sha2",
"shlex",
"smol",
"snippet_provider",
"task",
"tempfile",
"text",
@@ -13043,6 +13063,7 @@ dependencies = [
"gpui",
"gpui_tokio",
"http_client",
"json_schema_store",
"language",
"language_extension",
"language_model",
@@ -14810,6 +14831,7 @@ dependencies = [
"paths",
"schemars 1.0.1",
"serde",
"serde_json",
"serde_json_lenient",
"snippet",
"util",
@@ -20240,6 +20262,7 @@ dependencies = [
"install_cli",
"itertools 0.14.0",
"journal",
"json_schema_store",
"keymap_editor",
"language",
"language_extension",