Standardize on CursorShape::Underline not Underscore (#19028)
Currently terminal.cursor_shape uses `underline` and `cursor_shape` uses `underscore`. This standardizes them so they use the same settings value. I think `underline` is the more common term and it matches the terminology used by VSCode, Alacritty, iTerm, etc. Note the protobuf enum `CursorShape::CursorUnderscore` remains unchanged. See also: - https://github.com/zed-industries/zed/pull/18530 - https://github.com/zed-industries/zed/pull/17572 Release Notes: - Settings: rename one `cursor_shape` from `underscore` to `underline` (breaking change).
This commit is contained in:
@@ -118,8 +118,8 @@
|
||||
// "bar"
|
||||
// 2. A block that surrounds the following character
|
||||
// "block"
|
||||
// 3. An underline that runs along the following character
|
||||
// "underscore"
|
||||
// 3. An underline / underscore that runs along the following character
|
||||
// "underline"
|
||||
// 4. A box drawn around the following character
|
||||
// "hollow"
|
||||
//
|
||||
@@ -684,8 +684,8 @@
|
||||
// "block"
|
||||
// 2. A vertical bar
|
||||
// "bar"
|
||||
// 3. An underline that runs along the following character
|
||||
// "underscore"
|
||||
// 3. An underline / underscore that runs along the following character
|
||||
// "underline"
|
||||
// 4. A box drawn around the following character
|
||||
// "hollow"
|
||||
//
|
||||
|
||||
Reference in New Issue
Block a user