From 4118f42d616d8ad4d7c6c0c692b7c8f081a22fec Mon Sep 17 00:00:00 2001 From: Cole Miller Date: Fri, 21 Feb 2025 19:06:03 -0500 Subject: [PATCH] Rename ExpandAllHunkDiffs to ExpandAllDiffHunks (#25369) This is more consistent with the nomenclature in the rest of Zed. Release Notes: - Renamed the `editor::ExpandAllHunkDiffs` action to `editor::ExpandAllDiffHunks` --- assets/keymaps/default-linux.json | 2 +- assets/keymaps/default-macos.json | 2 +- crates/editor/src/actions.rs | 2 +- crates/editor/src/editor.rs | 2 +- crates/editor/src/editor_tests.rs | 10 +++++----- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/assets/keymaps/default-linux.json b/assets/keymaps/default-linux.json index f9ed4e25e7..83caf791d8 100644 --- a/assets/keymaps/default-linux.json +++ b/assets/keymaps/default-linux.json @@ -118,7 +118,7 @@ "ctrl-;": "editor::ToggleLineNumbers", "ctrl-k ctrl-r": "git::Restore", "ctrl-'": "editor::ToggleSelectedDiffHunks", - "ctrl-\"": "editor::ExpandAllHunkDiffs", + "ctrl-\"": "editor::ExpandAllDiffHunks", "ctrl-i": "editor::ShowSignatureHelp", "alt-g b": "editor::ToggleGitBlame", "menu": "editor::OpenContextMenu", diff --git a/assets/keymaps/default-macos.json b/assets/keymaps/default-macos.json index 889fa2e33e..b1e23423a1 100644 --- a/assets/keymaps/default-macos.json +++ b/assets/keymaps/default-macos.json @@ -133,7 +133,7 @@ "cmd-y": "git::StageAndNext", "cmd-shift-y": "git::UnstageAndNext", "cmd-'": "editor::ToggleSelectedDiffHunks", - "cmd-\"": "editor::ExpandAllHunkDiffs", + "cmd-\"": "editor::ExpandAllDiffHunks", "cmd-alt-g b": "editor::ToggleGitBlame", "cmd-i": "editor::ShowSignatureHelp", "ctrl-f12": "editor::GoToDeclaration", diff --git a/crates/editor/src/actions.rs b/crates/editor/src/actions.rs index 99b07f0a49..fad77993fa 100644 --- a/crates/editor/src/actions.rs +++ b/crates/editor/src/actions.rs @@ -280,7 +280,6 @@ gpui::actions!( DuplicateLineDown, DuplicateLineUp, DuplicateSelection, - ExpandAllHunkDiffs, ExpandMacroRecursively, FindAllReferences, Fold, @@ -425,3 +424,4 @@ action_as!(go_to_line, ToggleGoToLine as Toggle); action_with_deprecated_aliases!(editor, OpenSelectedFilename, ["editor::OpenFile"]); action_with_deprecated_aliases!(editor, ToggleSelectedDiffHunks, ["editor::ToggleHunkDiff"]); +action_with_deprecated_aliases!(editor, ExpandAllDiffHunks, ["editor::ExpandAllHunkDiffs"]); diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index a3a4dfd6bb..8a8eb8fbfd 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -12750,7 +12750,7 @@ impl Editor { pub fn expand_all_diff_hunks( &mut self, - _: &ExpandAllHunkDiffs, + _: &ExpandAllDiffHunks, _window: &mut Window, cx: &mut Context, ) { diff --git a/crates/editor/src/editor_tests.rs b/crates/editor/src/editor_tests.rs index 030a07d3f2..9e0b11c078 100644 --- a/crates/editor/src/editor_tests.rs +++ b/crates/editor/src/editor_tests.rs @@ -13306,7 +13306,7 @@ async fn test_diff_base_change_with_expanded_diff_hunks( executor.run_until_parked(); cx.update_editor(|editor, window, cx| { - editor.expand_all_diff_hunks(&ExpandAllHunkDiffs, window, cx); + editor.expand_all_diff_hunks(&ExpandAllDiffHunks, window, cx); }); executor.run_until_parked(); cx.assert_state_with_diff( @@ -13634,7 +13634,7 @@ async fn test_edits_around_expanded_insertion_hunks( executor.run_until_parked(); cx.update_editor(|editor, window, cx| { - editor.expand_all_diff_hunks(&ExpandAllHunkDiffs, window, cx); + editor.expand_all_diff_hunks(&ExpandAllDiffHunks, window, cx); }); executor.run_until_parked(); @@ -13905,7 +13905,7 @@ async fn test_edits_around_expanded_deletion_hunks( executor.run_until_parked(); cx.update_editor(|editor, window, cx| { - editor.expand_all_diff_hunks(&ExpandAllHunkDiffs, window, cx); + editor.expand_all_diff_hunks(&ExpandAllDiffHunks, window, cx); }); executor.run_until_parked(); @@ -14028,7 +14028,7 @@ async fn test_backspace_after_deletion_hunk(executor: BackgroundExecutor, cx: &m executor.run_until_parked(); cx.update_editor(|editor, window, cx| { - editor.expand_all_diff_hunks(&ExpandAllHunkDiffs, window, cx); + editor.expand_all_diff_hunks(&ExpandAllDiffHunks, window, cx); }); executor.run_until_parked(); @@ -14109,7 +14109,7 @@ async fn test_edit_after_expanded_modification_hunk( cx.set_diff_base(&diff_base); executor.run_until_parked(); cx.update_editor(|editor, window, cx| { - editor.expand_all_diff_hunks(&ExpandAllHunkDiffs, window, cx); + editor.expand_all_diff_hunks(&ExpandAllDiffHunks, window, cx); }); executor.run_until_parked();