oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove settings::Maybe (#42933)

Browse Source 
It's unclear how this would ever be useful

cc @probably-neb

Release Notes:

- N/A
This commit is contained in:
Conrad Irwin
2025-11-18 10:23:16 -07:00
committed by GitHub
parent 03132921c7
commit 3c4ca3f372
6 changed files with 7 additions and 223 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/settings_ui/src/page_data.rs
+2 -2
View File
@@ -33,10 +33,10 @@ pub(crate) fn settings_data(cx: &App) -> Vec<SettingsPage> {
SettingField {
json_path: Some("project_name"),
pick: |settings_content| {
settings_content.project.worktree.project_name.as_ref()?.as_ref().or(DEFAULT_EMPTY_STRING)
settings_content.project.worktree.project_name.as_ref().or(DEFAULT_EMPTY_STRING)
},
write: |settings_content, value| {
settings_content.project.worktree.project_name = settings::Maybe::Set(value.filter(|name| !name.is_empty()));
settings_content.project.worktree.project_name = value.filter(|name| !name.is_empty());
},
}
),
crates/settings_ui/src/settings_ui.rs
-1
View File
@@ -507,7 +507,6 @@ fn init_renderers(cx: &mut App) {
.add_basic_renderer::<settings::BufferLineHeightDiscriminants>(render_dropdown)
.add_basic_renderer::<settings::AutosaveSettingDiscriminants>(render_dropdown)
.add_basic_renderer::<settings::WorkingDirectoryDiscriminants>(render_dropdown)
.add_basic_renderer::<settings::MaybeDiscriminants>(render_dropdown)
.add_basic_renderer::<settings::IncludeIgnoredContent>(render_dropdown)
.add_basic_renderer::<settings::ShowIndentGuides>(render_dropdown)
.add_basic_renderer::<settings::ShellDiscriminants>(render_dropdown)