Introduce MVP Dev Containers support (#44442)
Partially addresses #11473 MVP of dev containers with the following capabilities: - If in a project with `.devcontainer/devcontainer.json`, a pop-up notification will ask if you want to open the project in a dev container. This can be dismissed: <img width="1478" height="1191" alt="Screenshot 2025-12-08 at 3 15 23 PM" src="https://github.com/user-attachments/assets/ec2e20d6-28ec-4495-8f23-4c1d48a9ce78" /> - Similarly, if a `devcontainer.json` file is in the project, you can open a devcontainer (or go the devcontainer.json file for further editing) via the `open remote` modal: https://github.com/user-attachments/assets/61f2fdaa-2808-4efc-994c-7b444a92c0b1 *Limitations* This is a first release, and comes with some limitations: - Zed extensions are not managed in `devcontainer.json` yet. They will need to be installed either on host or in the container. Host + Container sync their extensions, so there is not currently a concept of what is installed in the container vs what is installed on host: they come from the same list of manifests - This implementation uses the [devcontainer CLI](https://github.com/devcontainers/cli) for its control plane. Hence, it does not yet support the `forwardPorts` directive. A single port can be opened with `appPort`. See reference in docs [here](https://github.com/devcontainers/cli/tree/main/example-usage#how-the-tool-examples-work) - Editing devcontainer.json does not automatically cause the dev container to be rebuilt. So if you add features, change images, etc, you will need to `docker kill` the existing dev container before proceeding. - Currently takes a hard dependency on `docker` being available in the user's `PATH`. Release Notes: - Added ability to Open a project in a DevContainer, provided a `.devcontainer/devcontainer.json` is present --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
This commit is contained in:
co-authored by
Danilo Leal
Danilo Leal
parent
a61bf33fb0
commit
3a84ec38ac
@@ -7780,7 +7780,7 @@ pub fn open_remote_project_with_new_connection(
|
||||
) -> Task<Result<Vec<Option<Box<dyn ItemHandle>>>>> {
|
||||
cx.spawn(async move |cx| {
|
||||
let (workspace_id, serialized_workspace) =
|
||||
serialize_remote_project(remote_connection.connection_options(), paths.clone(), cx)
|
||||
deserialize_remote_project(remote_connection.connection_options(), paths.clone(), cx)
|
||||
.await?;
|
||||
|
||||
let session = match cx
|
||||
@@ -7834,7 +7834,7 @@ pub fn open_remote_project_with_existing_connection(
|
||||
) -> Task<Result<Vec<Option<Box<dyn ItemHandle>>>>> {
|
||||
cx.spawn(async move |cx| {
|
||||
let (workspace_id, serialized_workspace) =
|
||||
serialize_remote_project(connection_options.clone(), paths.clone(), cx).await?;
|
||||
deserialize_remote_project(connection_options.clone(), paths.clone(), cx).await?;
|
||||
|
||||
open_remote_project_inner(
|
||||
project,
|
||||
@@ -7936,7 +7936,7 @@ async fn open_remote_project_inner(
|
||||
Ok(items.into_iter().map(|item| item?.ok()).collect())
|
||||
}
|
||||
|
||||
fn serialize_remote_project(
|
||||
fn deserialize_remote_project(
|
||||
connection_options: RemoteConnectionOptions,
|
||||
paths: Vec<PathBuf>,
|
||||
cx: &AsyncApp,
|
||||
|
||||
Reference in New Issue
Block a user