oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reland "Remove cx from ThemeSettings" (#39720)

Browse Source 
- **Reapply "Remove cx from ThemeSettings (#38836)" (#39691)**
- **Fix theme loading races**

Closes #ISSUE

Release Notes:

- N/A
This commit is contained in:
Conrad Irwin
2025-10-08 17:36:52 +02:00
committed by GitHub
parent 70af11ef2a
commit 1d1c799b4b
60 changed files with 395 additions and 462 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/repl/src/jupyter_settings.rs
+1 -1
View File
@@ -19,7 +19,7 @@ impl JupyterSettings {
}
impl Settings for JupyterSettings {
fn from_settings(content: &settings::SettingsContent, _cx: &mut App) -> Self {
fn from_settings(content: &settings::SettingsContent) -> Self {
let jupyter = content.editor.jupyter.clone().unwrap();
Self {
kernel_selections: jupyter.kernel_selections.unwrap_or_default(),
crates/repl/src/repl_settings.rs
+1 -2
View File
@@ -1,4 +1,3 @@
use gpui::App;
use settings::Settings;
/// Settings for configuring REPL display and behavior.
@@ -17,7 +16,7 @@ pub struct ReplSettings {
}
impl Settings for ReplSettings {
fn from_settings(content: &settings::SettingsContent, _cx: &mut App) -> Self {
fn from_settings(content: &settings::SettingsContent) -> Self {
let repl = content.repl.as_ref().unwrap();
Self {