acp: Fix spawning login task (#38567)

Reverts #38175, which is not correct, since in fact we do need to
pre-quote the command and arguments for the shell when using
`SpawnInTerminal` (although we should probably change the API so that
this isn't necessary). Then, applies the same fix as #38565 to fix the
root cause of being unable to spawn the login task on macOS, or in any
case where the command/args contain spaces.

Release Notes:

- Fixed being unable to login with Claude Code or Gemini using the
terminal.

This commit is contained in:

Cole Miller

2025-09-20 14:14:55 -04:00

committed by

GitHub

parent f5c2e4b49e

commit 18df6a81b4

3 changed files with 17 additions and 19 deletions

Cargo.lock

Generated

View File

@@ -419,6 +419,7 @@ dependencies = [
  "serde_json",
  "serde_json_lenient",
  "settings",
  "shlex",
  "smol",
  "streaming_diff",
  "task",