oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1906 from zed-industries/mouse-down-capture-on-click-fix

Browse Source 
Fix mouse down falling through popovers
This commit is contained in:
Kay Simmons
2022-11-18 13:10:50 -08:00
committed by GitHub
parent d090d230e2 75b8a12ab3
commit 0c50c0959d
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/gpui/src/presenter.rs
+3 -1
View File
@@ -485,7 +485,7 @@ impl Presenter {
} }
// `event_consumed` should only be true if there are any handlers for this event. // `event_consumed` should only be true if there are any handlers for this event.
let mut event_consumed = false; let mut event_consumed = event_cx.handled;
if let Some(callbacks) = valid_region.handlers.get(&mouse_event.handler_key()) { if let Some(callbacks) = valid_region.handlers.get(&mouse_event.handler_key()) {
event_consumed = true; event_consumed = true;
for callback in callbacks { for callback in callbacks {
@@ -499,6 +499,8 @@ impl Presenter {
} }
} }
any_event_handled |= event_cx.handled;
// For bubbling events, if the event was handled, don't continue dispatching. // For bubbling events, if the event was handled, don't continue dispatching.
// This only makes sense for local events which return false from is_capturable. // This only makes sense for local events which return false from is_capturable.
if event_consumed && mouse_event.is_capturable() { if event_consumed && mouse_event.is_capturable() {