WIP

crates/editor/src/completions.rs

@@ -0,0 +1,28 @@
+use futures::Future;
+use gpui::Task;
+use smallvec::{smallvec, SmallVec};
+use text::Anchor;
+
+use crate::Editor;
+
+struct Completions {
+    trigger_characters: SmallVec<[char; 1]>,
+    language: Option<String>,
+    provider: Box<dyn Fn(&mut Editor, &Anchor, &str) -> Option<Task<String>>>,
+}
+
+impl Completions {
+    fn new(f: impl Fn(&mut Editor, &Anchor, &str) -> Option<Task<String>> + 'static) -> Self {
+        Self {
+            trigger_characters: smallvec![],
+            language: None,
+            provider: Box::new(f),
+        }
+    }
+}
+
+impl Editor {
+    /// Provide completions to the editor when the given character is typed
+    ///
+    fn provide_completions(config: Completions) {}
+}

crates/editor/src/element.rs

@@ -2543,18 +2543,21 @@ impl EditorElement {
 
             move |event: &MouseUpEvent, phase, cx| {
                 if phase == DispatchPhase::Bubble
-                    && interactive_bounds.visibly_contains(&event.position, cx)
                 {
-                    editor.update(cx, |editor, cx| {
-                        Self::mouse_up(
-                            editor,
-                            event,
-                            &position_map,
-                            text_bounds,
-                            &stacking_order,
-                            cx,
-                        )
-                    });
+                    // if interactive_bounds.visibly_contains(&event.position, cx) {
+                        editor.update(cx, |editor, cx| {
+                            Self::mouse_up(
+                                editor,
+                                event,
+                                &position_map,
+                                text_bounds,
+                                &stacking_order,
+                                cx,
+                            )
+                        });
+                    // } else {
+
+                    // }
                 }
             }
         });